From: Manjunath Patil <manjunath.b.patil@oracle.com>
To: Juergen Gross <jgross@suse.com>,
boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
roger.pau@citrix.com
Cc: axboe@kernel.dk, xen-devel@lists.xenproject.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path
Date: Tue, 30 Oct 2018 09:27:43 -0700 [thread overview]
Message-ID: <bffbe7ff-afc9-c1b6-698f-fe3228a38760@oracle.com> (raw)
In-Reply-To: <65b5d648-d9dc-9248-751c-b6e15109b52e@suse.com>
Thank you Juergen for your comments.
I will soon send v2 patch.
-Thanks,
Manjunath
On 10/30/2018 12:04 AM, Juergen Gross wrote:
> On 29/10/2018 19:31, Manjunath Patil wrote:
>> info->nr_rings isn't adjusted in case of ENOMEM error from
>> negotiate_mq(). This leads to kernel panic in error path.
>>
>> Typical call stack involving panic -
>> #8 page_fault at ffffffff8175936f
>> [exception RIP: blkif_free_ring+33]
>> RIP: ffffffffa0149491 RSP: ffff8804f7673c08 RFLAGS: 00010292
>> ...
>> #9 blkif_free at ffffffffa0149aaa [xen_blkfront]
>> #10 talk_to_blkback at ffffffffa014c8cd [xen_blkfront]
>> #11 blkback_changed at ffffffffa014ea8b [xen_blkfront]
>> #12 xenbus_otherend_changed at ffffffff81424670
>> #13 backend_changed at ffffffff81426dc3
>> #14 xenwatch_thread at ffffffff81422f29
>> #15 kthread at ffffffff810abe6a
>> #16 ret_from_fork at ffffffff81754078
>>
>> Though either of my changes avoid the panic, I included both the
>> changes. This issue got introduced with "7ed8ce1 xen-blkfront: move
>> negotiate_mq to cover all cases of new VBDs"
> Please us the correct format for specifying another commit.
>
>> Signed-off-by: Manjunath Patil <manjunath.b.patil@oracle.com>
> Can you please add a "Fixes:" tag and "Cc: stable@vger.kernel.org" ?
>
>> ---
>> drivers/block/xen-blkfront.c | 7 +++++--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>> index 429d201..dc8fe25 100644
>> --- a/drivers/block/xen-blkfront.c
>> +++ b/drivers/block/xen-blkfront.c
>> @@ -1350,8 +1350,10 @@ static void blkif_free(struct blkfront_info *info, int suspend)
>> if (info->rq)
>> blk_mq_stop_hw_queues(info->rq);
>>
>> - for (i = 0; i < info->nr_rings; i++)
>> - blkif_free_ring(&info->rinfo[i]);
>> + if (info->rinfo) {
>> + for (i = 0; i < info->nr_rings; i++)
>> + blkif_free_ring(&info->rinfo[i]);
>> + }
> I'd drop this change.
>
>>
>> kfree(info->rinfo);
>> info->rinfo = NULL;
>> @@ -1919,6 +1921,7 @@ static int negotiate_mq(struct blkfront_info *info)
>> GFP_KERNEL);
>> if (!info->rinfo) {
>> xenbus_dev_fatal(info->xbdev, -ENOMEM, "allocating ring_info structure");
>> + info->nr_rings = 0;
>> return -ENOMEM;
>> }
>
> Juergen
>
next prev parent reply other threads:[~2018-10-30 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 18:31 [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path Manjunath Patil
2018-10-30 7:04 ` Juergen Gross
2018-10-30 16:27 ` Manjunath Patil [this message]
2018-10-30 10:39 ` Roger Pau Monné
2018-10-30 16:29 ` [Xen-devel] " Manjunath Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bffbe7ff-afc9-c1b6-698f-fe3228a38760@oracle.com \
--to=manjunath.b.patil@oracle.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).