From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B64CC43461 for ; Wed, 9 Sep 2020 16:48:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5F312166E for ; Wed, 9 Sep 2020 16:48:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730865AbgIIQsF (ORCPT ); Wed, 9 Sep 2020 12:48:05 -0400 Received: from codesynthesis.com ([142.44.161.217]:34250 "EHLO codesynthesis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730986AbgIIQrk (ORCPT ); Wed, 9 Sep 2020 12:47:40 -0400 X-Greylist: delayed 4199 seconds by postgrey-1.27 at vger.kernel.org; Wed, 09 Sep 2020 12:47:39 EDT Received: from brak.codesynthesis.com (unknown [105.226.107.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by codesynthesis.com (Postfix) with ESMTPSA id 851435F138; Wed, 9 Sep 2020 14:09:48 +0000 (UTC) Received: by brak.codesynthesis.com (Postfix, from userid 1000) id 9751F1A800C4; Wed, 9 Sep 2020 16:09:43 +0200 (SAST) Date: Wed, 9 Sep 2020 16:09:43 +0200 From: Boris Kolpackov To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] kconfig: fix incomplete type 'struct gstr' warning Message-ID: References: <20200908221638.2782778-1-masahiroy@kernel.org> <20200908221638.2782778-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200908221638.2782778-2-masahiroy@kernel.org> Organization: Code Synthesis User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masahiro Yamada writes: > Currently, get_relations_str() is declared before the struct gstr > definition. Yes, I also ran into this while building the kconfig code with MSVC. I just moved the struct gstr definition before lkc_proto.h #include but your fix works just as well. Acked-by: Boris Kolpackov > BTW, some are declared in lkc.h and some in lkc_proto.h, but the > difference is unclear. I guess some refactoring is needed. Yes, please. My (potentially incorrect) understanding is that lkc_proto.h was for functions that are not (or should not be) used by clients but should nevertheless have prototypes due to -Wmissing-prototypes. I, however, believe this no longer holds and so would vote to merge lkc_proto.h into lkc.h.