From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Weiyi Lu <weiyi.lu@mediatek.com>
Cc: Matthias Brugger <mbrugger@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: Add MT8167 power domains
Date: Fri, 30 Oct 2020 12:43:28 +0100 [thread overview]
Message-ID: <c00a5ba1-154d-66ab-2ac7-c504e2e87b3e@collabora.com> (raw)
In-Reply-To: <20201027131122.374046-1-fparent@baylibre.com>
Hi Fabien,
Thank you for the patch and base it on [0]
On 27/10/20 14:11, Fabien Parent wrote:
> Add power domains dt-bindings for MT8167.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>
> This patch depends on the SCPSYS PM domains driver [0].
>
> v2:
> * Implement on top of new SCPSYS PM domains driver [0]
>
> [0] https://patchwork.kernel.org/project/linux-mediatek/list/?series=370737
>
> .../power/mediatek,power-controller.yaml | 2 ++
> include/dt-bindings/power/mt8167-power.h | 18 ++++++++++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 include/dt-bindings/power/mt8167-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> index 0318ffb1133c..73e5452c3a5d 100644
> --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> @@ -23,6 +23,7 @@ properties:
>
> compatible:
> enum:
> + - mediatek,mt8167-power-controller
> - mediatek,mt8173-power-controller
> - mediatek,mt8183-power-controller
> - mediatek,mt8192-power-controller
> @@ -59,6 +60,7 @@ patternProperties:
> reg:
> description: |
> Power domain index. Valid values are defined in:
> + "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain.
> "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain.
> "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain.
> "include/dt-bindings/power/mt8192-power.h" - for MT8192 type power domain.
> diff --git a/include/dt-bindings/power/mt8167-power.h b/include/dt-bindings/power/mt8167-power.h
> new file mode 100644
> index 000000000000..7e3babfc2eef
> --- /dev/null
> +++ b/include/dt-bindings/power/mt8167-power.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * Copyright (c) 2020 MediaTek Inc.
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_MT8167_POWER_H
> +#define _DT_BINDINGS_POWER_MT8167_POWER_H
> +
> +#define MT8167_POWER_DOMAIN_MM 0
> +#define MT8167_POWER_DOMAIN_DISP 0
Is that correct? Both domains have the same index?
> +#define MT8167_POWER_DOMAIN_VDEC 1
> +#define MT8167_POWER_DOMAIN_ISP 2
> +#define MT8167_POWER_DOMAIN_CONN 3
> +#define MT8167_POWER_DOMAIN_MFG_ASYNC 4
> +#define MT8167_POWER_DOMAIN_MFG_2D 5
> +#define MT8167_POWER_DOMAIN_MFG 6
> +
> +#endif /* _DT_BINDINGS_POWER_MT8167_POWER_H */
>
next prev parent reply other threads:[~2020-10-30 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:11 [PATCH v2 1/2] dt-bindings: power: Add MT8167 power domains Fabien Parent
2020-10-27 13:11 ` [PATCH v2 2/2] soc: mediatek: pm-domains: Add support for mt8167 Fabien Parent
2020-10-30 11:47 ` Enric Balletbo i Serra
2020-10-30 11:43 ` Enric Balletbo i Serra [this message]
2020-10-30 19:03 ` [PATCH v2 1/2] dt-bindings: power: Add MT8167 power domains Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00a5ba1-154d-66ab-2ac7-c504e2e87b3e@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=robh+dt@kernel.org \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).