From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E73CC4727D for ; Tue, 6 Oct 2020 11:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D87162080A for ; Tue, 6 Oct 2020 11:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601983744; bh=vV/cWTk5oZ3xCfPmOW1JyTYnqQAJ5XkLf+0bV/y1Ito=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=xe63TcvLzeSYUoa+ZM7V96U6pEFezt7P70VSKf41GKQ+Wmj4k7sSmxW5oBfcCQ6o0 P5pbC/1mzxppRJmxf93NTCQ1kHzp59pysoSsWXShcSVCEtZ0wo0DYv8YZQ1AiwCKl9 3n/TQnVe2vlww/ocQH4ZGu9sRTGBaT6IQuKsv1jc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726482AbgJFL3E (ORCPT ); Tue, 6 Oct 2020 07:29:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:38396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgJFL3D (ORCPT ); Tue, 6 Oct 2020 07:29:03 -0400 Received: from tleilax.poochiereds.net (68-20-15-154.lightspeed.rlghnc.sbcglobal.net [68.20.15.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8ECD62078E; Tue, 6 Oct 2020 11:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601983743; bh=vV/cWTk5oZ3xCfPmOW1JyTYnqQAJ5XkLf+0bV/y1Ito=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Jlhl4S6lFeJYtGWHmUA4l515wPAaDd/izhoqUtrYXjms0ElqbF3M1ArUgFO1ky40k zer6Zj9SWbb2ipxs05ptZWJ6MDYoZRPh+rtKtTZ8YbwdQuR8Z44fKxafme5xp9Yxo5 ryw9iFW4AEoas3dmsQFu+N/Z05Z69uSV6dPaytRg= Message-ID: Subject: Re: [PATCH 3/7] ceph: Promote to unsigned long long before shifting From: Jeff Layton To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: ericvh@gmail.com, lucho@ionkov.net, viro@zeniv.linux.org.uk, idryomov@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-btrfs@vger.kernel.org, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, stable@vger.kernel.org Date: Tue, 06 Oct 2020 07:29:00 -0400 In-Reply-To: <20201004180428.14494-4-willy@infradead.org> References: <20201004180428.14494-1-willy@infradead.org> <20201004180428.14494-4-willy@infradead.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-04 at 19:04 +0100, Matthew Wilcox (Oracle) wrote: > On 32-bit systems, this shift will overflow for files larger than 4GB. > > Cc: stable@vger.kernel.org > Fixes: 61f68816211e ("ceph: check caps in filemap_fault and page_mkwrite") > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/ceph/addr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 6ea761c84494..970e5a094035 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -1522,7 +1522,7 @@ static vm_fault_t ceph_filemap_fault(struct vm_fault *vmf) > struct ceph_inode_info *ci = ceph_inode(inode); > struct ceph_file_info *fi = vma->vm_file->private_data; > struct page *pinned_page = NULL; > - loff_t off = vmf->pgoff << PAGE_SHIFT; > + loff_t off = (loff_t)vmf->pgoff << PAGE_SHIFT; > int want, got, err; > sigset_t oldset; > vm_fault_t ret = VM_FAULT_SIGBUS; Good catch! Would you like us to take this in via the ceph tree, or are you planning to submit altogether upstream? Either way: Reviewed-by: Jeff Layton