From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7E9C433E4 for ; Wed, 24 Mar 2021 21:28:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF79261A23 for ; Wed, 24 Mar 2021 21:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238351AbhCXV2T (ORCPT ); Wed, 24 Mar 2021 17:28:19 -0400 Received: from mga06.intel.com ([134.134.136.31]:35577 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233849AbhCXV2E (ORCPT ); Wed, 24 Mar 2021 17:28:04 -0400 IronPort-SDR: AIynuTeax0lSDR4QNNDrAwjv5zKQly0i/YD/y0BUrNCul06y1zxVSONEJ2DYy4nAgY8oUOJjJV biZiQbh9rRyw== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="252146191" X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="252146191" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 14:28:01 -0700 IronPort-SDR: WfPWxzgv6hRguRTx0Lc0se0H/IbC6vbec18pdDFxd4+6q0LrD3loM5RVaRgzQbGak0sV9tw53y 2EfXrYrBhmaA== X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="442424773" Received: from aksagira-mobl2.amr.corp.intel.com ([10.209.125.174]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 14:27:54 -0700 Message-ID: Subject: Re: [PATCH 00/25] Rid W=1 warnings from HID From: Srinivas Pandruvada To: Lee Jones Cc: linux-kernel@vger.kernel.org, Alexandre Torgue , Anssi Hannula , Benjamin Tissoires , Bruno =?ISO-8859-1?Q?Pr=E9mont?= , Christian =?ISO-8859-1?Q?K=F6nig?= , Daniel Drubin , Dario Pagani , dri-devel@lists.freedesktop.org, Henrik Rydberg , Jiri Kosina , Jonathan Cameron , Kai-Heng Feng , Kim Kuparinen , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-usb@vger.kernel.org, Lopez Casado , "L. Vinyard, Jr" , Masaki Ota , Maxime Coquelin , message to , Michael Haboustak , Rushikesh S Kadam , Sumit Semwal , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Vojtech Pavlik , Zhang Lixu Date: Wed, 24 Mar 2021 14:27:54 -0700 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-03-24 at 17:33 +0000, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > For changes in drivers/hid/intel-ish-hid folder Acked-by: Srinivas Pandruvada > Lee Jones (25): > HID: intel-ish-hid: Remove unused variable 'err' > HID: ishtp-hid-client: Move variable to where it's actually used > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > HID: intel-ish: Supply some missing param descriptions > HID: intel-ish: Fix a naming disparity and a formatting error > HID: usbhid: Repair a formatting issue in a struct description > HID: intel-ish-hid: Fix a little doc-rot > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > HID: hid-alps: Correct struct misnaming > HID: intel-ish-hid: Fix potential copy/paste error > HID: hid-core: Fix incorrect function name in header > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name > in > header > HID: ishtp-hid-client: Fix incorrect function name > report_bad_packet() > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > HID: hid-picolcd_core: Remove unused variable 'ret' > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and > demote > abuses > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > HID: hid-uclogic-params: Ensure function names are present and > correct > in kernel-doc headers > HID: hid-sensor-custom: Remove unused variable 'ret' > HID: wacom_sys: Demote kernel-doc abuse > HID: hid-sensor-hub: Remove unused struct member 'quirks' > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > definition > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting > issues > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler > warning > > drivers/hid/hid-alps.c | 2 +- > drivers/hid/hid-core.c | 2 +- > drivers/hid/hid-kye.c | 2 +- > drivers/hid/hid-logitech-hidpp.c | 7 +-- > drivers/hid/hid-picolcd_core.c | 5 +-- > drivers/hid/hid-sensor-custom.c | 5 +-- > drivers/hid/hid-sensor-hub.c | 4 +- > drivers/hid/hid-thrustmaster.c | 24 +++++------ > drivers/hid/hid-uclogic-params.c | 8 ++-- > drivers/hid/hid-uclogic-rdesc.c | 2 +- > drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +- > drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++------ > ---- > drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++-- > drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- > drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +--- > drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++- > drivers/hid/intel-ish-hid/ishtp/client.c | 5 +-- > drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +- > drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +- > drivers/hid/usbhid/hid-pidff.c | 4 +- > drivers/hid/usbhid/usbkbd.c | 2 +- > drivers/hid/wacom_sys.c | 2 +- > include/linux/intel-ish-client-if.h | 8 +++- > 24 files changed, 90 insertions(+), 81 deletions(-) > > Cc: Alexandre Torgue > Cc: Anssi Hannula > Cc: Benjamin Tissoires > Cc: "Bruno Prémont" > Cc: "Christian König" > Cc: Daniel Drubin > Cc: Dario Pagani > Cc: dri-devel@lists.freedesktop.org > Cc: Henrik Rydberg > Cc: Jiri Kosina > Cc: Jonathan Cameron > Cc: Kai-Heng Feng > Cc: Kim Kuparinen > Cc: "Krzysztof Wilczyński" > Cc: Lee Jones > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-iio@vger.kernel.org > Cc: linux-input@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-usb@vger.kernel.org > Cc: Lopez Casado > Cc: "L. Vinyard, Jr" > Cc: Masaki Ota > Cc: Maxime Coquelin > Cc: message to > Cc: Michael Haboustak > Cc: Rushikesh S Kadam > Cc: Srinivas Pandruvada > Cc: Sumit Semwal > Cc: "Uwe Kleine-König" > Cc: Vojtech Pavlik > Cc: Zhang Lixu