From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E458C35671 for ; Sat, 22 Feb 2020 13:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2385720702 for ; Sat, 22 Feb 2020 13:20:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="pbjwEldc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbgBVNUB (ORCPT ); Sat, 22 Feb 2020 08:20:01 -0500 Received: from ssl.serverraum.org ([176.9.125.105]:37605 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726839AbgBVNUA (ORCPT ); Sat, 22 Feb 2020 08:20:00 -0500 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 76409230E1; Sat, 22 Feb 2020 14:19:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1582377597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PflziWWXiKohVr7J/dPsgitwa5siLhHLOsrVLro5scE=; b=pbjwEldcNAGilr2/TDnDGnXIvqKiZgrPi0/vQHx7dcls5Gp/xYMX4nW2wQZ4IKY2cYV5XR VrwTjzlTOgDJ3uXQuWUWo0YeLBokBJ6+9vs/9zRj28a6yj4bZXKlYc6uhtizwrC9BDcsso ax63FT5E9w/xVSPK/P0LRTf+PglPByQ= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 22 Feb 2020 14:19:57 +0100 From: Michael Walle To: Vladimir Oltean Cc: Andrew Lunn , "David S. Miller" , devicetree@vger.kernel.org, Florian Fainelli , lkml , Mark Rutland , netdev , Rob Herring , Shawn Guo , Vivien Didelot Subject: Re: [PATCH v2 net-next/devicetree 4/5] arm64: dts: fsl: ls1028a: add node for Felix switch In-Reply-To: References: <20200219151259.14273-5-olteanv@gmail.com> <20200222113829.32431-1-michael@walle.cc> Message-ID: X-Sender: michael@walle.cc User-Agent: Roundcube Webmail/1.3.10 X-Spamd-Bar: / X-Rspamd-Server: web X-Rspamd-Queue-Id: 76409230E1 X-Spamd-Result: default: False [-0.10 / 15.00]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[dt]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[]; DBL_PROHIBIT(0.00)[0.0.0.0:email,0.0.0.4:email]; RCPT_COUNT_SEVEN(0.00)[11]; NEURAL_HAM(-0.00)[-0.674]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[lunn.ch,davemloft.net,vger.kernel.org,gmail.com,arm.com,kernel.org]; MID_RHS_MATCH_FROM(0.00)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vladimir, Am 2020-02-22 13:25, schrieb Vladimir Oltean: > Hi Michael, > > On Sat, 22 Feb 2020 at 13:38, Michael Walle wrote: >> >> Hi, >> > >> > + >> > + enetc_port2: ethernet@0,2 { >> > + compatible = "fsl,enetc"; >> > + reg = <0x000200 0 0 0 0>; >> > + phy-mode = "gmii"; >> Can we disable this port by default in this dtsi? As mentioned in the >> other >> mail, I'd prefer to have all ports disabled because it doesn't make >> sense >> to have this port while having all the external ports disabled. >> > > Ok. What would you want to happen with the "ethernet" property? Do you > want the board dts to set that too? That's something I've also thought about. And now that you've mention this, I think it makes more sense to have that in the board too. Because if you have the freedom to use either eno2/swp4 or eno3/swp5, then if I choose the second one I'd have to delete the ethernet property from the first, correct? I actually thought about adding the ethernet property to both; but (1) I don't know if that is even possible (given that one is always disabled) and (2) if one want to use the second port as an additional link to the switch you'd have to remove the ethernet property on that port. correct? >> > + /* Internal port with DSA tagging */ >> > + mscc_felix_port4: port@4 { >> > + reg = <4>; >> > + phy-mode = "internal"; >> > + ethernet = <&enetc_port2>; >> Likewise, I'd prefer to have this disabled. >> > > Ok. > >> > + enetc_port3: ethernet@0,6 { >> > + compatible = "fsl,enetc"; >> > + reg = <0x000600 0 0 0 0>; >> > + status = "disabled"; >> > + phy-mode = "gmii"; >> shouldn't the status be after the phy-mode property? > > Why? I thought that would be a rule. I just had a quick look on some other device trees before and they all has the status property as the last property (before any subnodes). I might be mistaken. If so, you could do it for consistency reasons ;) all status property in the ls1028a.dtsi are the last ones. -michael