From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2E4CC433E1 for ; Thu, 27 Aug 2020 15:23:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F2612087D for ; Thu, 27 Aug 2020 15:23:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbgH0PXO (ORCPT ); Thu, 27 Aug 2020 11:23:14 -0400 Received: from foss.arm.com ([217.140.110.172]:57090 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728544AbgH0L36 (ORCPT ); Thu, 27 Aug 2020 07:29:58 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57705106F; Thu, 27 Aug 2020 04:05:17 -0700 (PDT) Received: from [192.168.1.190] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 373753F68F; Thu, 27 Aug 2020 04:05:15 -0700 (PDT) Subject: Re: [PATCH 28/35] kasan: define KASAN_GRANULE_SIZE for HW_TAGS To: Catalin Marinas , Andrey Konovalov Cc: Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <07455abaab13824579c1b8e50cc038cf8a0f3369.1597425745.git.andreyknvl@google.com> <20200827104147.GG29264@gaia> From: Vincenzo Frascino Message-ID: Date: Thu, 27 Aug 2020 12:07:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827104147.GG29264@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/27/20 11:41 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:10PM +0200, Andrey Konovalov wrote: >> Hardware tag-based KASAN has granules of MTE_GRANULE_SIZE. Define >> KASAN_GRANULE_SIZE to MTE_GRANULE_SIZE for CONFIG_KASAN_HW_TAGS. >> >> Signed-off-by: Andrey Konovalov >> --- >> mm/kasan/kasan.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h >> index 1d3c7c6ce771..4d8e229f8e01 100644 >> --- a/mm/kasan/kasan.h >> +++ b/mm/kasan/kasan.h >> @@ -5,7 +5,13 @@ >> #include >> #include >> >> +#if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) >> #define KASAN_GRANULE_SIZE (1UL << KASAN_SHADOW_SCALE_SHIFT) >> +#else >> +#include > > You could only include the new asm/mte-def.h file (currently mte_asm.h). > Agreed, we should only include asm/mte-def.h here since after the suggested modification will be sufficient for the purpose. >> +#define KASAN_GRANULE_SIZE (MTE_GRANULE_SIZE) >> +#endif >> + >> #define KASAN_GRANULE_MASK (KASAN_GRANULE_SIZE - 1) >> >> #define KASAN_TAG_KERNEL 0xFF /* native kernel pointers tag */ >> -- >> 2.28.0.220.ged08abb693-goog >> > -- Regards, Vincenzo