From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Konrad Dybcio <konradybcio@gmail.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] arm64: dts: qcom: pm8994: Add thermal-zones for temp alarm
Date: Mon, 5 Oct 2020 17:25:32 +0200 [thread overview]
Message-ID: <c03ace9d-d983-c1f8-ab74-ed585aeb2364@linaro.org> (raw)
In-Reply-To: <20201005150313.149754-4-konradybcio@gmail.com>
On 05/10/2020 17:03, Konrad Dybcio wrote:
> This will shut down the platform in case the PMIC overheats.
>
> Signed-off-by: Konrad Dybcio <konradybcio@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/pm8994.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> index 7825208b0d8b..9ab5657f7d23 100644
> --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> @@ -4,6 +4,30 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> +/ {
> + thermal-zones {
> + pm8994 {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = <&pm8994_temp>;
> +
> + trips {
> + pm8994_alert0: pm8994-alert0 {
> + temperature = <95000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
Don't you want to add a 'hot' trip point, so userspace can get the
notification and have an opportunity to do some action like unplugging
some CPU before a wild shutdown happens ?
> + pm8994_crit: pm8994-crit {
> + temperature = <125000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> + };
> +};
> +
> &spmi_bus {
>
> pmic@0 {
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-10-05 15:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 15:03 [PATCH 00/11] pm8994 / msm8992/4 DT updates Konrad Dybcio
2020-10-05 15:03 ` [PATCH 01/11] arm64: dts: qcom: pm8994: Add VADC node Konrad Dybcio
2020-10-05 15:03 ` [PATCH 02/11] arm64: dts: qcom: pm8994: Add temperature alarm node Konrad Dybcio
2020-10-05 15:03 ` [PATCH 03/11] arm64: dts: qcom: pm8994: Add thermal-zones for temp alarm Konrad Dybcio
2020-10-05 15:25 ` Daniel Lezcano [this message]
2020-10-05 15:28 ` Konrad Dybcio
2020-10-05 15:39 ` Daniel Lezcano
2020-10-05 15:49 ` Konrad Dybcio
2020-10-05 16:03 ` Daniel Lezcano
2020-10-05 15:03 ` [PATCH 04/11] arm64: dts: qcom: pm8994: Fix up spmi-gpio node Konrad Dybcio
2020-10-05 15:03 ` [PATCH 05/11] arm64: dts: qcom: msm8992: Add support for SDHCI2 Konrad Dybcio
2020-10-06 7:49 ` kernel test robot
2020-10-06 21:15 ` Konrad Dybcio
2020-10-05 15:03 ` [PATCH 06/11] arm64: dts: qcom: msm8994: Add SDHCI2 node Konrad Dybcio
2020-10-06 14:21 ` kernel test robot
2020-10-06 21:15 ` Konrad Dybcio
2020-10-05 15:03 ` [PATCH 07/11] arm64: dts: qcom: msm8992: Add BLSP_I2C1 support Konrad Dybcio
2020-10-05 15:03 ` [PATCH 08/11] arm64: dts: qcom: talkman: Add Synaptics RMI4 touchscreen Konrad Dybcio
2020-10-05 15:03 ` [PATCH 09/11] arm64: dts: qcom: msm8994: Add USB support Konrad Dybcio
2020-10-05 15:03 ` [PATCH 10/11] arm64: dts: qcom: msm8992: " Konrad Dybcio
2020-10-05 15:03 ` [PATCH 11/11] arm64: dts: qcom: Add support for Microsoft Lumia 950 XL (Cityman) Konrad Dybcio
2020-10-05 15:14 ` Konrad Dybcio
2020-11-11 4:56 ` Bjorn Andersson
2020-11-05 11:03 ` [PATCH 00/11] pm8994 / msm8992/4 DT updates Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c03ace9d-d983-c1f8-ab74-ed585aeb2364@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).