From: Alexandre Ghiti <alex@ghiti.fr>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
"H . Peter Anvin" <hpa@zytor.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Palmer Dabbelt <palmer@sifive.com>,
Will Deacon <will.deacon@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Hanjun Guo <guohanjun@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH v3 0/2] Hugetlbfs support for riscv
Date: Thu, 4 Jul 2019 08:33:44 +0200 [thread overview]
Message-ID: <c06441fd-0022-8fb9-36b0-2f5d956c3ed5@ghiti.fr> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1907031344330.10620@viisi.sifive.com>
On 7/4/19 12:57 AM, Paul Walmsley wrote:
> Hi Alex,
>
> Thanks for writing and testing these patches, and thanks for your patience
> waiting for reviews and testing.
No problem :)
> On Mon, 1 Jul 2019, Alexandre Ghiti wrote:
>
>> This series introduces hugetlbfs support for both riscv 32/64. Riscv32
>> is architecturally limited to huge pages of size 4MB whereas riscv64 has
>> 2MB/1G huge pages support. Transparent huge page support is not
>> implemented here, I will submit another series later.
>>
> [ ... ]
>
>> This series was validated using libhugetlbfs testsuite ported to riscv64
>> without linker script support.
>> (https://github.com/AlexGhiti/libhugetlbfs.git, branch dev/alex/riscv).
>>
>> - libhugetlbfs testsuite on riscv64/2M:
>> - brk_near_huge triggers an assert in malloc.c, does not on x86.
> I was able to reproduce the 2MB megapages test results on rv64 QEMU. On a
> HiFive Unleashed, though, a few more tests fail:
>
> - icache_hygiene fails ("icache unclean")
>
> # LD_LIBRARY_PATH=obj64 ./tests/obj64/icache-hygiene
> Starting testcase "./tests/obj64/icache-hygiene", pid 732
> SIGILL at 0x15559fff80 (sig_expected=0x15559fff80)
> SIGILL at 0x1555dfff80 (sig_expected=0x1555dfff80)
> SIGILL at 0x15561fff80 (sig_expected=0x15561fff80)
> SIGILL at 0x15565fff80 (sig_expected=0x15565fff80)
> SIGILL at 0x15569fff80 (sig_expected=0x15569fff80)
> SIGILL at 0x1556dfff80 (sig_expected=(nil))
> FAIL SIGILL somewhere unexpected
> #
>
> - One of the heapshrink tests fails ("Heap did not shrink")
>
> # LD_PRELOAD="obj64/libhugetlbfs_privutils.so obj64/libhugetlbfs.so tests/obj64/libheapshrink.so" HUGETLB_MORECORE_SHRINK=yes HUGETLB_MORECORE=yes tests/obj64/heapshrink
> Starting testcase "tests/obj64/heapshrink", pid 753
> FAIL Heap did not shrink
> #
>
> Some of these may be related to the top-down mmap work, but there might be
> more work to do on actual hardware.
I don't think this is related to top-down mmap layout, this test only
mmaps a huge page.
It might be interesting to see more verbose messages adding
HUGETLB_VERBOSE=99
when launching the test.
>
>> - libhugetlbfs testsuite on riscv64/1G:
>> - brk_near_huge triggers an assert in malloc.c, does not on x86.
>> - mmap-gettest, mmap-cow: testsuite passes the number of default free
>> pages as parameters and then fails for 1G which is not the default.
>> Otherwise succeeds when given the right number of pages.
>> - map_high_truncate_2 fails on x86 too: 0x60000000 is not 1G aligned
>> and fails at line 694 of fs/hugetlbfs/inode.c.
>> - heapshrink on 1G fails on x86 too, not investigated.
>> - counters.sh on 1G fails on x86 too: alloc_surplus_huge_page returns
>> NULL in case of gigantic pages.
>> - icache-hygiene succeeds after patch #3 of this series which lowers
>> the base address of mmap.
>> - fallocate_stress.sh on 1G never ends, on x86 too, not investigated.
> I can reproduce some of these here on QEMU. But for reasons that are
> unclear to me, 1G gigapages aren't working on the HiFive Unleashed here.
>
> In any case, these patches are clearly a good start, so I've queued
> them for v5.3.
>
>
> - Paul
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-07-04 6:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 17:58 [PATCH v3 0/2] Hugetlbfs support for riscv Alexandre Ghiti
2019-07-01 17:58 ` [PATCH v3 1/2] x86, arm64: Move ARCH_WANT_HUGE_PMD_SHARE config in arch/Kconfig Alexandre Ghiti
2019-07-01 18:51 ` Paul Walmsley
2019-07-02 15:37 ` Alexandre Ghiti
2019-07-02 1:27 ` Hanjun Guo
2019-07-02 15:38 ` Alexandre Ghiti
2019-07-02 13:22 ` Christoph Hellwig
2019-07-01 17:59 ` [PATCH v3 2/2] riscv: Introduce huge page support for 32/64bit kernel Alexandre Ghiti
2019-07-02 13:24 ` Christoph Hellwig
2019-07-02 15:39 ` Alexandre Ghiti
2019-07-03 22:57 ` [PATCH v3 0/2] Hugetlbfs support for riscv Paul Walmsley
2019-07-04 6:33 ` Alexandre Ghiti [this message]
2019-07-04 11:35 ` Paul Walmsley
2019-07-07 15:14 ` Alex Ghiti
2019-07-03 23:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c06441fd-0022-8fb9-36b0-2f5d956c3ed5@ghiti.fr \
--to=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=guohanjun@huawei.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).