From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC66C352A3 for ; Tue, 11 Feb 2020 21:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C4FE20842 for ; Tue, 11 Feb 2020 21:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581455217; bh=ial5lfm1joGz3c4sbCOYuWw3kSyd3YsJFbgXFfG8r/g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=tPNMjFsQW3R0e4gpft2YY6W17N+Ive4XwUqni0A8t749HX5N5K8pwwDBugXoqqonI C3GpMIP3VOOUcsqc9GFYHhxwneErVsakPSIZB1aLLtzitoIKKF1Eu4Kz1tt0dRGqdJ VVgM9zVPUGUNKBm+3F57BHc87J2ENxGhuppUcM7M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731949AbgBKVG4 (ORCPT ); Tue, 11 Feb 2020 16:06:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:43586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729031AbgBKVG4 (ORCPT ); Tue, 11 Feb 2020 16:06:56 -0500 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DC6820708; Tue, 11 Feb 2020 21:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581455215; bh=ial5lfm1joGz3c4sbCOYuWw3kSyd3YsJFbgXFfG8r/g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=msfipC7T9DKYbMKWk/VLVW4IMh7VnAItA5wtAxaobNWwXfYmHZ/X/Ymmq8lsnLEGN Wu+pQMJuctk58waK3nUpMbXZ4UDxTjq9yOcqf5kjKIuTY+pyZfL45ptaFYdIywNhS+ cyd182nfjlqDLv5IJ8aOb17XICywoddq/X6ljmcc= Subject: Re: [PATCH v3 7/7] selftests/exec: Add READ_IMPLIES_EXEC tests To: Kees Cook Cc: Ingo Molnar , Hector Marco-Gisbert , Catalin Marinas , Will Deacon , Jason Gunthorpe , Jann Horn , Russell King , x86@kernel.org, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah References: <20200210193049.64362-1-keescook@chromium.org> <20200210193049.64362-8-keescook@chromium.org> <4f8a5036-dc2a-90ad-5fc8-69560a5dd78e@kernel.org> <202002111124.0A334167@keescook> From: shuah Message-ID: Date: Tue, 11 Feb 2020 14:06:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <202002111124.0A334167@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/20 12:25 PM, Kees Cook wrote: > On Tue, Feb 11, 2020 at 11:11:21AM -0700, shuah wrote: >> On 2/10/20 12:30 PM, Kees Cook wrote: >>> In order to check the matrix of possible states for handling >>> READ_IMPLIES_EXEC across native, compat, and the state of PT_GNU_STACK, >>> add tests for these execution conditions. >>> >>> Signed-off-by: Kees Cook >> >> No issues for this to go through tip. >> >> A few problems to fix first. This fails to compile when 32-bit libraries >> aren't installed. It should fail the 32-bit part and run other checks. > > Do you mean the Makefile should detect the missing compat build deps and > avoid building them? Testing compat is pretty important to this test, so > it seems like missing the build deps causing the build to fail is the > correct action here. This is likely true for the x86/ selftests too. > > What would you like this to do? > selftests/x86 does this already and runs the dependency check in x86/Makefile. check_cc.sh:# check_cc.sh - Helper to test userspace compilation support Makefile:CAN_BUILD_I386 := $(shell ./check_cc.sh $(CC) trivial_32bit_program.c -m32) Makefile:CAN_BUILD_X86_64 := $(shell ./check_cc.sh $(CC) trivial_64bit_program.c) Makefile:CAN_BUILD_WITH_NOPIE := $(shell ./check_cc.sh $(CC) trivial_program.c -no-pie) Take a look and see if you can leverage this. thanks, -- Shuah