From: Mason <slash.tmp@free.fr>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Mark Rutland <mark.rutland@arm.com>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v2] irqchip: Add support for tango interrupt router
Date: Sat, 15 Jul 2017 15:06:06 +0200 [thread overview]
Message-ID: <c0bd235a-9035-2002-31eb-e68710b076fd@free.fr> (raw)
In-Reply-To: <dfb86360-2247-65bb-602b-5c21029709fd@free.fr>
On 12/07/2017 18:39, Mason wrote:
> 128 inputs, 24 outputs (to GIC SPI 0-23)
>
> There might be a few things wrong with this driver. When I
> cat /proc/interrupts the interrupt count appears to be bogus
> (as if level IRQ counts are added to edge IRQ counts).
OK, I found the issue.
It occurred on the interrupt lines that stay high when
the HW block is idle, so I mishandled them on every
level interrupt.
I have two remaining issues:
1) In the ISR, I get the hwirq from the GIC. What is the
API to translate that to the SPI? I'm currently just
subtracting 32.
2) I'm currently using a single domain, with a
handle_simple_irq domain handler. That's probably
wrong. Should I define two domains, one for edge
IRQs and one for level IRQs, and use the appropriate
handler? Should both domain have 128 entries?
(I.e. are they indexed by the hwirq?)
And should I use linear or tree?
Regards.
next prev parent reply other threads:[~2017-07-15 13:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 13:42 [RFC PATCH v1] irqchip: Add support for tango interrupt router Mason
2017-06-06 15:52 ` Thomas Petazzoni
2017-07-11 15:56 ` Mason
2017-07-12 16:39 ` [RFC PATCH v2] " Mason
2017-07-15 13:06 ` Mason [this message]
2017-07-15 23:46 ` Mason
2017-07-17 15:36 ` [RFC PATCH v3] " Mason
2017-07-17 21:22 ` Mason
2017-07-18 14:21 ` [PATCH v4] " Mason
2017-07-25 15:26 ` [PATCH v5] " Mason
2017-08-01 16:56 ` [PATCH v6] " Mason
2017-08-07 12:47 ` Marc Zyngier
2017-08-20 17:22 ` Mason
2017-08-21 16:13 ` Mason
2017-08-23 10:58 ` Marc Zyngier
2017-08-23 15:45 ` Mason
2017-08-28 13:58 ` [PATCH v7] irqchip: Add support for tango interrupt mapper Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0bd235a-9035-2002-31eb-e68710b076fd@free.fr \
--to=slash.tmp@free.fr \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
--cc=thibaud_cornic@sigmadesigns.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).