From: William Cohen <wcohen@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org
Subject: Re: [PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor
Date: Thu, 1 Feb 2018 16:52:16 -0500 [thread overview]
Message-ID: <c0d905c6-948d-98b1-85ca-5aa8b5090435@redhat.com> (raw)
In-Reply-To: <20180201205129.GC4835@kernel.org>
On 02/01/2018 03:51 PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 01, 2018 at 10:12:59AM -0500, William Cohen escreveu:
>> On 02/01/2018 09:43 AM, Arnaldo Carvalho de Melo wrote:
>>> Em Tue, Jan 30, 2018 at 10:28:13PM -0500, William Cohen escreveu:
>>>> Add JSON metrics for ARM Cortex-A53 Processor
>>>
>>> Hi Will, would it be possible to you include an URL for the document
>>> that served as a reference to you to write these files? Did you use some
>>> script?
>>
>> Hi Arnaldo,
>
>> I can certainly add the reference to section "12.9 Events" of the ARM
>> Cortex -A53 MPCore Processor Revision: r0p4 Technical Reference Manual
>> to the patch. That would be useful for people to know where to look
>> for additional information about the events.
>
Hi Arnaldo,
The ARM Cortex A53 manual is available at:
http://infocenter.arm.com/help/topic/com.arm.doc.ddi0500g/DDI0500G_cortex_a53_trm.pdf
It would probably be useful to include that URL in the commit information to make it easier for people to look up the information.
-Will
> I'll take these clarifications and add it to your patch, that I am
> applying now, please let me know if you have anything else to add and
> I'll ammend it if I get it before I send it upstream.
>
>> Unlike the Intel processors there isn't a script that automatically
>> generated these files. The patch was manually generated from the
>> documentation and the previous oprofile ARM Cortex ac53 event file
>> patch I made.
>
> Thanks a lot for this extra information,
>
> - Arnaldo
>
next prev parent reply other threads:[~2018-02-01 21:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 3:28 [PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor William Cohen
2018-02-01 14:43 ` Arnaldo Carvalho de Melo
2018-02-01 15:12 ` William Cohen
2018-02-01 20:51 ` Arnaldo Carvalho de Melo
2018-02-01 21:52 ` William Cohen [this message]
2018-02-02 13:36 ` Arnaldo Carvalho de Melo
2018-02-13 12:03 ` [tip:perf/urgent] " tip-bot for William Cohen
2018-02-16 9:33 ` tip-bot for William Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d905c6-948d-98b1-85ca-5aa8b5090435@redhat.com \
--to=wcohen@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).