From: Khalid Aziz <khalid@gonehiking.org>
To: Colin King <colin.king@canonical.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: BusLogic: use %X for u32 sized integer rather than %lX
Date: Fri, 30 Jul 2021 15:57:16 -0600 [thread overview]
Message-ID: <c0d9a73c-3817-ea12-8cda-8970ac849191@gonehiking.org> (raw)
In-Reply-To: <20210730095031.26981-1-colin.king@canonical.com>
On 7/30/21 3:50 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> An earlier fix changed the print format specifier for adapter->bios_addr
> to use %lX however the integer is a u32 so the fix was wrong. Fix this
> by using the correct %X format specifier.
>
> Addresses-Coverity: ("Invalid type in argument")
> Fixes: 43622697117c ("scsi: BusLogic: use %lX for unsigned long rather than %X")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/BusLogic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index adddcd589941..bd615db5c58c 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -1711,7 +1711,7 @@ static bool __init blogic_reportconfig(struct blogic_adapter *adapter)
> if (adapter->adapter_bus_type != BLOGIC_PCI_BUS) {
> blogic_info(" DMA Channel: None, ", adapter);
> if (adapter->bios_addr > 0)
> - blogic_info("BIOS Address: 0x%lX, ", adapter,
> + blogic_info("BIOS Address: 0x%X, ", adapter,
> adapter->bios_addr);
> else
> blogic_info("BIOS Address: None, ", adapter);
>
Acked-by: Khalid Aziz <khalid@gonehiking.org>
next prev parent reply other threads:[~2021-07-30 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 9:50 [PATCH] scsi: BusLogic: use %X for u32 sized integer rather than %lX Colin King
2021-07-30 21:57 ` Khalid Aziz [this message]
2021-08-01 17:28 ` Martin K. Petersen
2021-08-02 8:11 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d9a73c-3817-ea12-8cda-8970ac849191@gonehiking.org \
--to=khalid@gonehiking.org \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).