From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754251AbcIUG4o (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 02:56:44 -0400
Received: from mga06.intel.com ([134.134.136.31]:32332 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751449AbcIUG4m (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 02:56:42 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,372,1470726000"; 
   d="scan'208";a="1054200471"
Subject: Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get
 added to the state
To: Mike Lothian <mike@fireburn.co.uk>, Lyude <cpaul@redhat.com>
References: <1471463761-26796-1-git-send-email-cpaul@redhat.com>
 <1471463761-26796-6-git-send-email-cpaul@redhat.com>
 <CAHbf0-HOLeg6p3K=df3eOk0nuu-FcR63VkMUVUSFKnK4=SJJ5g@mail.gmail.com>
Cc: intel-gfx@lists.freedesktop.org,
        =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Matt Roper <matthew.d.roper@intel.com>,
        Radhakrishna Sripada <radhakrishna.sripada@intel.com>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>, stable@vger.kernel.org,
        Daniel Vetter <daniel.vetter@intel.com>
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Message-ID: <c0ee1dc0-ca47-9d0c-6def-a9a0f1921e62@linux.intel.com>
Date: Wed, 21 Sep 2016 08:56:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAHbf0-HOLeg6p3K=df3eOk0nuu-FcR63VkMUVUSFKnK4=SJJ5g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hey,

Op 20-09-16 om 20:45 schreef Mike Lothian:
> Hi
>
> I've bisected back to this commit in the drm-intel-nightly branch
>
> 05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first bad commit
> commit 05a76d3d6ad1ee9f9814f88949cc9305fc165460
> Author: Lyude <cpaul@redhat.com>
> Date:   Wed Aug 17 15:55:57 2016 -0400
>
>    drm/i915/skl: Ensure pipes with changed wms get added to the state
>
>    If we're enabling a pipe, we'll need to modify the watermarks on all
>    active planes. Since those planes won't be added to the state on
>    their own, we need to add them ourselves.
>
>    Signed-off-by: Lyude <cpaul@redhat.com>
>    Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>    Cc: stable@vger.kernel.org
>    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>    Cc: Daniel Vetter <daniel.vetter@intel.com>
>    Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>    Cc: Hans de Goede <hdegoede@redhat.com>
>    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>    Link: http://patchwork.freedesktop.org/patch/msgid/1471463761-26796-6-git-send-email-cpaul@redhat.com
>
> The symptoms I'm seeing look like tearing at the top of the screen and
> it's especially noticeable in Chrome - reverting this commit makes the
> issue go away
>
> Let me know if you'd like me to raise a bug
Please do so, it's nice to refer to when making a fix for it.

Could you attach the contents of /sys/kernel/debug/dri/0/i915_ddb_info for working and not-working in it?

~Maarten