From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbcHZMub (ORCPT ); Fri, 26 Aug 2016 08:50:31 -0400 Received: from mout.web.de ([212.227.17.12]:51217 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcHZMu3 (ORCPT ); Fri, 26 Aug 2016 08:50:29 -0400 Subject: [PATCH 2/8] cris-cryptocop: Improve determination of sizes in five functions To: linux-cris-kernel@axis.com, Adam Buchbinder , Dave Hansen , Ingo Molnar , Jesper Nilsson , Jiri Kosina , Mikael Starvik , Thomas Gleixner References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Fri, 26 Aug 2016 14:50:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:2A1TdmEiPtxWHUdFf+mn8AIcq/BTX2hmYXH4lT27O+2bzuQnxxQ 3gmtGQsXkpwPh8Gd0z4Nd/rPbzi4hb+xXkaRHi0LsvuMFP1qaa+Zt7P7+no/cHtbnN7/Lzx wxwmT797hxIn+PwJ4SLeLTO6YWcMp2vCF/Kg5AaVwWdC0g6XV4ahCNQ1BAJWOR2HVEkr0oY sM9oYNT4L67GmcUsP1eLA== X-UI-Out-Filterresults: notjunk:1;V01:K0:nUqFQtZ+pbk=:nA8Mjxnf8+PjpbTzywx2E0 h2cVVv94urXeGPVQemafDJMoQ02RW1bjw7hsXmdAq7Qs3zJE8LzKkioss2vTlkh/S8U5jGX1Q 3/RWYSReoAdRpyOaiSPrBFWzbs/kZ9PGYENmDpW6ebBLV36Ys7zZrVtXEzT4s/dRRh6HQY8Sx 3M5hXaSn0y3LSi7CtnfDvM4T6B9hGy0Kugx5lyMcZ2dmm/hF03Yx1C/V6qd465hTDttGBNwDL L6UJnhgMbXHzm8LgHeEypQmbU/6elqgOmE798UYn563gfT9yXhQYME/p3wINsflBoWeEo/YP3 OHcMu+4M8QcuMnNwYGZCw/VazzH7HnjtwY3gcCBX9hp3KALnSCTELdLcdhfW/66YPL3uay/MH XurSXWNxIAvAjtU8wRVM+b4oVCjIU/ZJh3/ipmU33yUOertPUlBrO9LJFFbA+wnW9QZz9XHcj zBKGvqXHXe87qln4mM6qBQILU51GdRva8vpdS50mt2RByM2bquwOj5jLD73CwPsEbKpN5zaOs fvDs+H/jDmsHyhLhcwDjl/4HvG/eirz2Ab4nGD5JHDwxFMKQLxA35LXGxghVobpozBsOogiXG jVpW+4RI3M8HqBbTBPvFegv1R5ddQgxqD1mBPmCd9fACYxWW1iq4JRBOG9swcyHPqdPSS0hrw A8zcsYFXHkTbPT4f08k/zoHlUCA7pGUPYvfzP2w1fiEFLoZXNuQRRLblXMMgooAnj3rgEf/W5 wFlv/aMnY9NKc3N5TBqFe0oTB00tYlV1Ll100qpn6Un9xGeTRUfb1jNqXGOKZInDmEsshk856 4bGOJtO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 22:32:27 +0200 Replace the specification of data structures by references for variables as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/cris/arch-v32/drivers/cryptocop.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c index 1632abc..8e04b92 100644 --- a/arch/cris/arch-v32/drivers/cryptocop.c +++ b/arch/cris/arch-v32/drivers/cryptocop.c @@ -323,7 +323,7 @@ static struct cryptocop_dma_desc *alloc_cdesc(int alloc_flag) spin_unlock_irqrestore(&descr_pool_lock, flags); cdesc->from_pool = 1; } else { - cdesc = kmalloc(sizeof(struct cryptocop_dma_desc), alloc_flag); + cdesc = kmalloc(sizeof(*cdesc), alloc_flag); if (!cdesc) { DEBUG_API(printk("alloc_cdesc: kmalloc\n")); return NULL; @@ -1526,7 +1526,7 @@ int cryptocop_new_session(cryptocop_session_id *sid, struct cryptocop_transform_ return -EINVAL; } - sess = kmalloc(sizeof(struct cryptocop_session), alloc_flag); + sess = kmalloc(sizeof(*sess), alloc_flag); if (!sess){ DEBUG_API(printk("cryptocop_new_session, kmalloc cryptocop_session\n")); return -ENOMEM; @@ -2247,7 +2247,7 @@ static int cryptocop_job_setup(struct cryptocop_prio_job **pj, struct cryptocop_ int alloc_flag = operation->in_interrupt ? GFP_ATOMIC : GFP_KERNEL; void *iop_alloc_ptr = NULL; - *pj = kmalloc(sizeof (struct cryptocop_prio_job), alloc_flag); + *pj = kmalloc(sizeof(**pj), alloc_flag); if (!*pj) return -ENOMEM; DEBUG(printk("cryptocop_job_setup: operation=0x%p\n", operation)); @@ -2552,12 +2552,12 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig return -EFAULT; } - cop = kmalloc(sizeof(struct cryptocop_operation), GFP_KERNEL); + cop = kmalloc(sizeof(*cop), GFP_KERNEL); if (!cop) { DEBUG_API(printk("cryptocop_ioctl_process: kmalloc\n")); return -ENOMEM; } - jc = kmalloc(sizeof(struct ioctl_job_cb_ctx), GFP_KERNEL); + jc = kmalloc(sizeof(*jc), GFP_KERNEL); if (!jc) { DEBUG_API(printk("cryptocop_ioctl_process: kmalloc\n")); err = -ENOMEM; @@ -3082,7 +3082,7 @@ static int cryptocop_ioctl_create_session(struct inode *inode, struct file *filp ti_csum.next = tis; tis = &ti_csum; } /* (sop.csum != cryptocop_csum_none) */ - dev = kmalloc(sizeof(struct cryptocop_private), GFP_KERNEL); + dev = kmalloc(sizeof(*dev), GFP_KERNEL); if (!dev){ DEBUG_API(printk("create session, alloc dev\n")); return -ENOMEM; -- 2.9.3