From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
To: Alain Volmat <alain.volmat@st.com>, <wsa@the-dreams.de>,
<robh+dt@kernel.org>
Cc: <mark.rutland@arm.com>, <mcoquelin.stm32@gmail.com>,
<alexandre.torgue@st.com>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <fabrice.gasnier@st.com>
Subject: Re: [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1
Date: Tue, 22 Oct 2019 15:41:10 +0200 [thread overview]
Message-ID: <c10c0652-3f9e-ea5c-98f2-206af86b0fe4@st.com> (raw)
In-Reply-To: <1571145118-3522-1-git-send-email-alain.volmat@st.com>
Hello
Looks good
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Thx
Regards
On 10/15/19 3:11 PM, Alain Volmat wrote:
> Remove the following warning:
>
> drivers/i2c/busses/i2c-stm32f7.c:315:
> warning: cannot understand function prototype:
> 'struct stm32f7_i2c_spec i2c_specs[] =
>
> Replace a comment starting with /** by simply /* to avoid having
> it interpreted as a kernel-doc comment.
>
> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
> Signed-off-by: Alain Volmat <alain.volmat@st.com>
> ---
> Changes in v2: update commit description
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index d36cf08461f7..7aa4a47792a7 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
> struct regmap *regmap;
> };
>
> -/**
> +/*
> * All these values are coming from I2C Specification, Version 6.0, 4th of
> * April 2014.
> *
>
next prev parent reply other threads:[~2019-10-22 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 13:11 [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1 Alain Volmat
2019-10-22 13:41 ` Pierre Yves MORDRET [this message]
2019-10-24 18:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c10c0652-3f9e-ea5c-98f2-206af86b0fe4@st.com \
--to=pierre-yves.mordret@st.com \
--cc=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).