From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E7EC282E1 for ; Thu, 23 May 2019 16:41:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E74120881 for ; Thu, 23 May 2019 16:41:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="FVFxuVHQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731141AbfEWQlx (ORCPT ); Thu, 23 May 2019 12:41:53 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:34364 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730893AbfEWQlx (ORCPT ); Thu, 23 May 2019 12:41:53 -0400 Received: by mail-pl1-f195.google.com with SMTP id w7so2982273plz.1 for ; Thu, 23 May 2019 09:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=QxLlMcpZF4s6oYuMc8pgq9hIU3JxTkHMlIXFqr7xT6c=; b=FVFxuVHQtP/UwFTrvUUdg8Mu0s5/ZUDGf2daY9CljgY4Zl/eofCrRMJ/MAnm6ezoIT rplSNc3PXLwYrNvnWuPWkQZ5arZ0V7jHonRDY6SAjRiwCNQvdK66+Qx80NtPSj+hwrxd +XksfxQqaFKOl0koZkqKitzGyEXCiDMNCw6xU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=QxLlMcpZF4s6oYuMc8pgq9hIU3JxTkHMlIXFqr7xT6c=; b=FerLrOA+Py5Rpa9r3ie/Z2ASwWWF0PFF354KXcCil06wY+JXSFm+tfRJToJ/SQD9kZ C2P8qj9ji+EzUSnLTN3Vgb6Hfis/yNn3Iit2GDEvjYNtQ+D02dTD7mTdeJ4UOiuF12HE qWF6x6bdC/pJt44i1DfR64f6mhlw14JbZv7MOwXiseSvUfhmYb9oupUFGN4cOLwLa0zw dUC+kNADAdhBw/z8q/Pa+bQ+454S7EPgdWkgcu7dH6TmhlSXTiKg8KEw1ny7zqEchKt7 kw6aCQBysGExy0r7I+9WopHg0dBenFfohbm+hFvhH17wHKsJBi4hW4EFzGAtoF6ae3fL hq5g== X-Gm-Message-State: APjAAAUnRndKg7w1O6LWImqJwI7+PceSoD+13ck5B6NmwyXP6Jkzj/GQ mwHJBAol0PoADvkueQC30LAl1A== X-Google-Smtp-Source: APXvYqz2ENEwFpcm+GtlaHW4ZEFkpatXoMtMl+mKUtN4o5Gt+iMf9QqM+Xlm6MebmUhMNU4q6gQbGA== X-Received: by 2002:a17:902:aa85:: with SMTP id d5mr98713790plr.245.1558629712674; Thu, 23 May 2019 09:41:52 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id g9sm27282487pgs.78.2019.05.23.09.41.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 May 2019 09:41:51 -0700 (PDT) Subject: Re: [PATCH 3/3] soc: qcom: mdt_loader: add offset to request_firmware_into_buf To: Greg Kroah-Hartman Cc: Luis Chamberlain , Andy Gross , David Brown , Alexander Viro , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson References: <20190523025113.4605-1-scott.branden@broadcom.com> <20190523025113.4605-4-scott.branden@broadcom.com> <20190523055212.GA22946@kroah.com> From: Scott Branden Message-ID: Date: Thu, 23 May 2019 09:41:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190523055212.GA22946@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote: > On Wed, May 22, 2019 at 07:51:13PM -0700, Scott Branden wrote: >> Adjust request_firmware_into_buf API to allow for portions >> of firmware file to be read into a buffer. mdt_loader still >> retricts request fo whole file read into buffer. >> >> Signed-off-by: Scott Branden >> --- >> drivers/soc/qcom/mdt_loader.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c >> index 1c488024c698..ad20d159699c 100644 >> --- a/drivers/soc/qcom/mdt_loader.c >> +++ b/drivers/soc/qcom/mdt_loader.c >> @@ -172,8 +172,11 @@ static int __qcom_mdt_load(struct device *dev, const struct firmware *fw, >> >> if (phdr->p_filesz) { >> sprintf(fw_name + fw_name_len - 3, "b%02d", i); >> - ret = request_firmware_into_buf(&seg_fw, fw_name, dev, >> - ptr, phdr->p_filesz); >> + ret = request_firmware_into_buf >> + (&seg_fw, fw_name, dev, >> + ptr, phdr->p_filesz, >> + 0, >> + KERNEL_PREAD_FLAG_WHOLE); > So, all that work in the first 2 patches for no real change at all? Why > are these changes even needed? The first two patches allow partial read of files into memory. Existing kernel drivers haven't need such functionality so, yes, there should be no real change with first two patches other than adding such partial file read support. We have a new driver in development which needs partial read of files supported in the kernel. > > And didn't you break this driver in patch 2/3? You can't fix it up > later here, you need to also resolve that in the 2nd patch. I thought the driver changes needs to be in a different patch. If required I can squash this driver change in with the request_firmware_into_buf change. But the 2nd patch won't work without the 1st patch either. So that would mean you now want all 3 patches for different subsystems squashed together? Please let me know how you would like the patch series submitted. > > thanks, > > greg k-h Regards,  Scott