From: <Mario_Limonciello@Dell.com>
To: <davem@davemloft.net>, <pali.rohar@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <andrew@lunn.ch>,
<hayeswang@realtek.com>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<anthony.wong@canonical.com>
Subject: RE: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date: Wed, 22 Jun 2016 22:11:17 +0000 [thread overview]
Message-ID: <c1292dba89864fd0a931aa160aaed7eb@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: 20160614.143521.2085426866285759820.davem@davemloft.net
> -----Original Message-----
> From: Limonciello, Mario
> Sent: Tuesday, June 14, 2016 5:27 PM
> To: 'David Miller' <davem@davemloft.net>; pali.rohar@gmail.com
> Cc: gregkh@linuxfoundation.org; andrew@lunn.ch;
> hayeswang@realtek.com; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; linux-usb@vger.kernel.org;
> anthony.wong@canonical.com
> Subject: RE: [PATCH v6] r8152: Add support for setting pass through MAC
> address on RTL8153-AD
>
> > -----Original Message-----
> > From: David Miller [mailto:davem@davemloft.net]
> > Sent: Tuesday, June 14, 2016 1:35 PM
> > To: pali.rohar@gmail.com
> > Cc: gregkh@linuxfoundation.org; andrew@lunn.ch; Limonciello, Mario
> > <Mario_Limonciello@Dell.com>; hayeswang@realtek.com; linux-
> > kernel@vger.kernel.org; netdev@vger.kernel.org; linux-
> > usb@vger.kernel.org; anthony.wong@canonical.com
> > Subject: Re: [PATCH v6] r8152: Add support for setting pass through MAC
> > address on RTL8153-AD
> >
> > From: Pali Rohár <pali.rohar@gmail.com>
> > Date: Tue, 14 Jun 2016 18:47:36 +0200
> >
> > > You have never seen two ethernet cards with same MAC addresses?
> Right
> > I
> > > have not seen two USB, but there is non zero chance that could happen.
> >
> > It would be an error scenerio, and something to be avoided.
> >
> > It is a valid and correct assumption that one is able to put
> > several devices at the same time on the same physical network
> > and expect it to work.
> >
> > The behavior added by the change in question invalidates that.
> >
> > I'm trying to consider the long term aspects of this, which is that if
> > more devices adopt this scheme we're in trouble if we blindly
> > interpret the MAC address in this way.
> >
>
> Do you mean if other manufacturers start to ship devices with
> RTL8135-AD's w/ this pass through bit set and people start to try to
> mix and match?
>
> > This firmware MAC property facility seems to be designed with only an
> > extremely narrow use case being considered.
>
> Yes, as I understand it this is the reason that it's only on such specific devices
> that the mac address pass through bit is actually set on the efuse.
David,
Did you have any more thoughts about this? I'm happy to make some other
adjustments to the patch, if you have some recommendations.
next prev parent reply other threads:[~2016-06-22 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:22 [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello
2016-06-11 5:51 ` David Miller
2016-06-11 15:39 ` Andrew Lunn
2016-06-11 17:42 ` David Miller
2016-06-14 15:08 ` Mario_Limonciello
2016-06-14 16:28 ` Pali Rohár
2016-06-14 16:40 ` Greg KH
2016-06-14 16:47 ` Pali Rohár
2016-06-14 16:55 ` Mario_Limonciello
2016-06-14 17:23 ` Andrew Lunn
2016-06-14 17:58 ` Mario_Limonciello
2016-06-14 18:35 ` David Miller
2016-06-14 22:27 ` Mario_Limonciello
2016-06-22 22:11 ` Mario_Limonciello [this message]
2016-07-11 21:54 ` Mario_Limonciello
2016-07-11 22:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1292dba89864fd0a931aa160aaed7eb@ausx13mpc124.AMER.DELL.COM \
--to=mario_limonciello@dell.com \
--cc=andrew@lunn.ch \
--cc=anthony.wong@canonical.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).