From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Maxim Levitsky <mlevitsk@redhat.com>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/7] kconfig: qconf: cleanup includes
Date: Tue, 30 Jun 2020 08:26:35 +0200 [thread overview]
Message-ID: <c138cd9af908952a85a0fc0f0ff30c57b0e547ba.1593498345.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1593498345.git.mchehab+huawei@kernel.org>
The usage of c-like include is deprecated on modern Qt
versions. Use the c++ style includes.
While here, remove uneeded and redundant ones, sorting
them on alphabetic order.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
scripts/kconfig/qconf.cc | 27 +++++++++------------------
scripts/kconfig/qconf.h | 14 +++++++-------
2 files changed, 16 insertions(+), 25 deletions(-)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index c0ac8f7b5f1a..0e06afa08908 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -4,27 +4,18 @@
* Copyright (C) 2015 Boris Barbulovski <bbarbulovski@gmail.com>
*/
-#include <qglobal.h>
-
-#include <QMainWindow>
-#include <QList>
-#include <qtextbrowser.h>
#include <QAction>
+#include <QApplication>
+#include <QCloseEvent>
+#include <QDesktopWidget>
#include <QFileDialog>
+#include <QLabel>
+#include <QLayout>
+#include <QList>
#include <QMenu>
-
-#include <qapplication.h>
-#include <qdesktopwidget.h>
-#include <qtoolbar.h>
-#include <qlayout.h>
-#include <qsplitter.h>
-#include <qlineedit.h>
-#include <qlabel.h>
-#include <qpushbutton.h>
-#include <qmenubar.h>
-#include <qmessagebox.h>
-#include <qregexp.h>
-#include <qevent.h>
+#include <QMenuBar>
+#include <QMessageBox>
+#include <QToolBar>
#include <stdlib.h>
diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
index c879d79ce817..d913a02967ae 100644
--- a/scripts/kconfig/qconf.h
+++ b/scripts/kconfig/qconf.h
@@ -3,17 +3,17 @@
* Copyright (C) 2002 Roman Zippel <zippel@linux-m68k.org>
*/
-#include <QTextBrowser>
-#include <QTreeWidget>
-#include <QMainWindow>
+#include <QCheckBox>
+#include <QDialog>
#include <QHeaderView>
-#include <qsettings.h>
+#include <QLineEdit>
+#include <QMainWindow>
#include <QPushButton>
#include <QSettings>
-#include <QLineEdit>
#include <QSplitter>
-#include <QCheckBox>
-#include <QDialog>
+#include <QTextBrowser>
+#include <QTreeWidget>
+
#include "expr.h"
class ConfigView;
--
2.26.2
next prev parent reply other threads:[~2020-06-30 6:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 6:26 [PATCH v3 0/7] Fix split view search and debug info navigation Mauro Carvalho Chehab
2020-06-30 6:26 ` Mauro Carvalho Chehab [this message]
2020-06-30 6:26 ` [PATCH v3 2/7] kconfig: qconf: make search fully work again on split mode Mauro Carvalho Chehab
2020-06-30 6:26 ` [PATCH v3 3/7] kconfig: qconf: make debug links work again Mauro Carvalho Chehab
2020-06-30 6:26 ` [PATCH v3 4/7] kconfig: qconf: re-implement setSelected() Mauro Carvalho Chehab
2020-06-30 6:26 ` [PATCH v3 5/7] kconfig: qconf: simplify the goBack() logic Mauro Carvalho Chehab
2020-06-30 6:26 ` [PATCH v3 6/7] kconfig: qconf: don't show goback button on splitMode Mauro Carvalho Chehab
2020-07-18 19:24 ` Maxim Levitsky
2020-06-30 6:26 ` [PATCH v3 7/7] kconfig: qconf: navigate menus on hyperlinks Mauro Carvalho Chehab
2020-06-30 6:48 ` [PATCH v3.1 " Mauro Carvalho Chehab
2020-07-01 15:21 ` Masahiro Yamada
2020-07-01 15:51 ` Mauro Carvalho Chehab
2020-07-01 15:55 ` Maxim Levitsky
2020-07-01 15:19 ` [PATCH v3 0/7] Fix split view search and debug info navigation Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c138cd9af908952a85a0fc0f0ff30c57b0e547ba.1593498345.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mlevitsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).