From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Geunyoung Kim <nenggun.kim@samsung.com>,
Junghak Sung <jh1009.sung@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Inki Dae <inki.dae@samsung.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: [PATCH 1/2] [media] cx25821: Drop Freeing of Workqueue
Date: Sat, 16 Jul 2016 14:41:49 +0530 [thread overview]
Message-ID: <c138d0a859516d8a4176c4ddb32b83119d4ad51c.1468659580.git.bhaktipriya96@gmail.com> (raw)
In-Reply-To: <cover.1468659580.git.bhaktipriya96@gmail.com>
Workqueues shouldn't be freed. destroy_workqueue should be used instead.
destroy_workqueue safely destroys a workqueue and ensures that all pending
work items are done before destroying the workqueue.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/media/pci/cx25821/cx25821-audio-upstream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx25821/cx25821-audio-upstream.c b/drivers/media/pci/cx25821/cx25821-audio-upstream.c
index 68dbc2d..05bd957 100644
--- a/drivers/media/pci/cx25821/cx25821-audio-upstream.c
+++ b/drivers/media/pci/cx25821/cx25821-audio-upstream.c
@@ -242,7 +242,7 @@ void cx25821_stop_upstream_audio(struct cx25821_dev *dev)
dev->_audioframe_count = 0;
dev->_audiofile_status = END_OF_FILE;
- kfree(dev->_irq_audio_queues);
+ destroy_workqueue(dev->_irq_audio_queues);
dev->_irq_audio_queues = NULL;
kfree(dev->_audiofilename);
--
2.1.4
next prev parent reply other threads:[~2016-07-16 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 9:10 [PATCH 0/2] Remove improper workqueue usage Bhaktipriya Shridhar
2016-07-16 9:11 ` Bhaktipriya Shridhar [this message]
2016-07-18 23:55 ` [PATCH 1/2] [media] cx25821: Drop Freeing of Workqueue Tejun Heo
2016-07-16 9:13 ` [PATCH 2/2] [media] cx25821: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-07-18 23:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c138d0a859516d8a4176c4ddb32b83119d4ad51c.1468659580.git.bhaktipriya96@gmail.com \
--to=bhaktipriya96@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=inki.dae@samsung.com \
--cc=jh1009.sung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=nenggun.kim@samsung.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).