From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergey Lisov <sleirsgoevy@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] devicetree: synopsys-dw-mshc-common: add "fifo-access-32bit" property
Date: Sat, 11 Mar 2023 16:50:58 +0100 [thread overview]
Message-ID: <c13993bc-9d12-f20e-de27-fa0b8a58ed33@linaro.org> (raw)
In-Reply-To: <1678548256.0817535-1-sleirsgoevy@gmail.com>
On 11/03/2023 16:22, Sergey Lisov wrote:
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Missing commit msg, which should answer why you are doing this and give
more background.
> ---
> .../devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml
> index 8dfad89c7..2bc5ac528 100644
> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml
> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml
> @@ -57,6 +57,12 @@ properties:
> force fifo watermark setting accordingly.
> $ref: /schemas/types.yaml#/definitions/flag
>
> + fifo-access-32bit:
Missing type boolean.
> + description:
> + Specifies that this device requires accesses to its 64-bit registers
> + to be done as pairs of 32-bit accesses, even on architectures where
> + readq is available.
And why the device would require this? If it has 64-bit registers in the
first place, they can be accessed in 64-bit. Otherwise these are not
64-bit registers, but just lower/upper 32-bit, right?
Also, why this cannot be implied from compatible? Why different boards
with same SoC should have different FIFO access?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-11 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 15:23 [PATCH 0/2] dw_mmc: fix DW MMC cores with 32-bit bus on 64-bit Linux systems Sergey Lisov
2023-03-11 15:22 ` [PATCH 1/2] devicetree: synopsys-dw-mshc-common: add "fifo-access-32bit" property Sergey Lisov
2023-03-11 15:50 ` Krzysztof Kozlowski [this message]
2023-03-11 17:40 ` Sergey Lisov
2023-03-11 17:57 ` broken subject? Krzysztof Kozlowski
2023-03-11 17:57 ` [PATCH 1/2] devicetree: synopsys-dw-mshc-common: add "fifo-access-32bit" property Sergey Lisov
2023-03-11 15:22 ` [PATCH 2/2] dw_mmc: add an option to force 32-bit accesses to 64-bit device registers Sergey Lisov
[not found] <640cc323.050a0220.8e83b.0e60@mx.google.com>
2023-03-11 18:08 ` [PATCH 1/2] devicetree: synopsys-dw-mshc-common: add "fifo-access-32bit" property Krzysztof Kozlowski
[not found] <640c80ff.050a0220.2983.0b8d@mx.google.com>
2023-03-11 15:58 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-03-11 12:54 Sergey Lisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c13993bc-9d12-f20e-de27-fa0b8a58ed33@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sleirsgoevy@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).