From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D329DC433F5 for ; Wed, 20 Apr 2022 06:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240912AbiDTG0X (ORCPT ); Wed, 20 Apr 2022 02:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232987AbiDTG0P (ORCPT ); Wed, 20 Apr 2022 02:26:15 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B6243A5CD for ; Tue, 19 Apr 2022 23:23:30 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KjrCG05VpzFqQb; Wed, 20 Apr 2022 14:20:58 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 20 Apr 2022 14:23:27 +0800 Subject: Re: [PATCH] mm/swap: Fix lost swap bits in unuse_pte() To: kernel test robot , Peter Xu CC: , , , , , , , , , , , , , , , References: <202204201313.QYiDBRbL-lkp@intel.com> From: Miaohe Lin Message-ID: Date: Wed, 20 Apr 2022 14:23:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <202204201313.QYiDBRbL-lkp@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/20 13:56, kernel test robot wrote: > Hi Peter, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on hnaz-mm/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845 > base: https://github.com/hnaz/linux-mm master > config: s390-randconfig-r023-20220420 (https://download.01.org/0day-ci/archive/20220420/202204201313.QYiDBRbL-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install s390 cross compiling tool for clang build > # apt-get install binutils-s390x-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/355ac3eb45402f7aab25b76af029d4390af05238 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845 > git checkout 355ac3eb45402f7aab25b76af029d4390af05238 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > The variable name is newpte. But it's written as new_pte latter. Many thanks for report! BTW: Since this is not a formal patch (no compile tested). Is Reported-by tag still needed? Thanks! > All errors (new ones prefixed by >>): > >>> mm/swapfile.c:1824:2: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'? > new_pte = pte_mkold(mk_pte(page, vma->vm_page_prot)); > ^~~~~~~ > newpte > mm/swapfile.c:1786:14: note: 'newpte' declared here > pte_t *pte, newpte; > ^ > mm/swapfile.c:1826:26: error: use of undeclared identifier 'new_pte' > pte = pte_mksoft_dirty(new_pte); > ^ > mm/swapfile.c:1828:23: error: use of undeclared identifier 'new_pte' > pte = pte_mkuffd_wp(new_pte); > ^ > mm/swapfile.c:1829:36: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'? > set_pte_at(vma->vm_mm, addr, pte, new_pte); > ^~~~~~~ > newpte > mm/swapfile.c:1786:14: note: 'newpte' declared here > pte_t *pte, newpte; > ^ > 4 errors generated. ... > 1839 >