From: rajeevny@codeaurora.org
To: Doug Anderson <dianders@chromium.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Clark <robdclark@gmail.com>, Lyude Paul <lyude@redhat.com>,
Jani Nikula <jani.nikula@intel.com>,
Rob Herring <robh@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
"Kristian H. Kristensen" <hoegsberg@chromium.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Sean Paul <seanpaul@chromium.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Krishna Manikandan <mkrishn@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [v7 1/5] drm/panel: add basic DP AUX backlight support
Date: Wed, 23 Jun 2021 11:45:24 +0530 [thread overview]
Message-ID: <c15947bb1566f176a2f534c52a7c3183@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=WJiA+RxaQA9xt7Tik_2pCEJo0+6b39Di8cfnSWGuKkJQ@mail.gmail.com>
Hi,
On 23-06-2021 00:03, Doug Anderson wrote:
> Hi,
>
> On Mon, Jun 21, 2021 at 11:38 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>>
>> > > I cannot see why you need the extra check on ->enabled?
>> > > Would it be sufficient to check backlight_is_blank() only?
>> >
>> > This extra check on bl->enabled flag is added to avoid enabling/disabling
>> > backlight again if it is already enabled/disabled.
>> > Using this flag way can know the transition between backlight blank and
>> > un-blank, and decide when to enable/disable the backlight.
>>
>> My point is that this should really not be needed, as it would cover
>> up
>> for some other bug whaere we try to do something twice that is not
>> needed. But I am less certain here so if you think it is needed, keep
>> it as is.
>
> I haven't tested this myself, but I believe that it is needed. I don't
> think the backlight update_status() function is like an enable/disable
> function. I believe it can be called more than one time even while the
> backlight is disabled. For instance, you can see that
> backlight_update_status() just blindly calls through to update the
> status. That function can be called for a number of reasons. Perhaps
> Rajeev can put some printouts to confirm but I think that if the
> backlight is "blanked" for whatever reason and you write to sysfs and
> change the backlight level you'll still get called again even though
> the backlight is still "disabled".
>
Yes, sysfs write will always try to update the backlight even though the
backlight is "blanked".
The "bl->enabled" check is also required to prevent unnecessary calls to
drm_edp_backlight_enable() during every backlight level change.
To confirm this, I have added few prints in
dp_aux_backlight_update_status() function and collected the logs.
(Copying the code here to make the review easy)
static int dp_aux_backlight_update_status(struct backlight_device *bd)
{
struct dp_aux_backlight *bl = bl_get_data(bd);
u16 brightness = backlight_get_brightness(bd);
int ret = 0;
+ pr_err("%s: brightness %d, _is_blank %d, bl->enabled %d\n",
__func__,
+ brightness, backlight_is_blank(bd), bl->enabled);
if (!backlight_is_blank(bd)) {
if (!bl->enabled) {
+ pr_err("%s: enabling backlight\n", __func__);
drm_edp_backlight_enable(bl->aux, &bl->info,
brightness);
bl->enabled = true;
return 0;
}
ret = drm_edp_backlight_set_level(bl->aux, &bl->info,
brightness);
} else {
if (bl->enabled) {
+ pr_err("%s: disabling backlight\n", __func__);
drm_edp_backlight_disable(bl->aux, &bl->info);
bl->enabled = false;
}
}
return ret;
}
LOGS
====
During boot
-----------
[ 4.752188] dp_aux_backlight_update_status: brightness 102, _is_blank
0, bl->enabled 0
[ 4.760447] dp_aux_backlight_update_status: enabling backlight
[ 5.503866] dp_aux_backlight_update_status: brightness 102, _is_blank
0, bl->enabled 1
[ 6.897355] dp_aux_backlight_update_status: brightness 103, _is_blank
0, bl->enabled 1
[ 6.938617] dp_aux_backlight_update_status: brightness 104, _is_blank
0, bl->enabled 1
[ 6.980634] dp_aux_backlight_update_status: brightness 105, _is_blank
0, bl->enabled 1
Turning Panel OFF
-----------------
localhost ~ # set_power_policy --ac_screen_dim_delay=5
--ac_screen_off_delay=10
localhost ~ #
[ 106.555140] dp_aux_backlight_update_status: brightness 145, _is_blank
0, bl->enabled 1
...
...
[ 111.679407] dp_aux_backlight_update_status: brightness 7, _is_blank
0, bl->enabled 1
[ 111.700302] dp_aux_backlight_update_status: brightness 4, _is_blank
0, bl->enabled 1
[ 111.720805] dp_aux_backlight_update_status: brightness 2, _is_blank
0, bl->enabled 1
[ 111.747486] dp_aux_backlight_update_status: brightness 0, _is_blank
1, bl->enabled 1
[ 111.755580] dp_aux_backlight_update_status: disabling backlight
[ 111.792344] dp_aux_backlight_update_status: brightness 0, _is_blank
1, bl->enabled 0
Changing brightness from sysfs while panel is off
--------------------------------------------------
(it will do nothing)
localhost ~ # echo 100 >
/sys/class/backlight/dp_aux_backlight/brightness
[ 352.754963] dp_aux_backlight_update_status: brightness 0, _is_blank
1, bl->enabled 0
localhost ~ # echo 200 >
/sys/class/backlight/dp_aux_backlight/brightness
[ 364.708048] dp_aux_backlight_update_status: brightness 0, _is_blank
1, bl->enabled 0
localhost ~ # echo 0 > /sys/class/backlight/dp_aux_backlight/brightness
[ 378.850978] dp_aux_backlight_update_status: brightness 0, _is_blank
1, bl->enabled 0
Turning Panel ON
----------------
[ 553.381745] dp_aux_backlight_update_status: brightness 0, _is_blank
0, bl->enabled 0
[ 553.418133] dp_aux_backlight_update_status: enabling backlight
[ 553.426397] dp_aux_backlight_update_status: brightness 159, _is_blank
0, bl->enabled 1
====
Thanks,
Rajeev
next prev parent reply other threads:[~2021-06-23 6:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 10:40 [v7 0/5] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20 Rajeev Nandan
2021-06-19 10:40 ` [v7 1/5] drm/panel: add basic DP AUX backlight support Rajeev Nandan
[not found] ` <20210620093141.GA703072@ravnborg.org>
2021-06-21 8:38 ` rajeevny
[not found] ` <20210621183828.GA918146@ravnborg.org>
2021-06-22 18:33 ` Doug Anderson
2021-06-23 6:15 ` rajeevny [this message]
2021-06-19 10:40 ` [v7 2/5] drm/panel-simple: Support DP AUX backlight Rajeev Nandan
2021-06-19 10:40 ` [v7 3/5] drm/panel-simple: Support for delays between GPIO & regulator Rajeev Nandan
2021-06-19 10:40 ` [v7 4/5] dt-bindings: display: simple: Add Samsung ATNA33XC20 Rajeev Nandan
2021-06-19 10:40 ` [v7 5/5] drm/panel-simple: " Rajeev Nandan
[not found] ` <20210620100147.GB703072@ravnborg.org>
2021-06-21 15:34 ` Doug Anderson
[not found] ` <20210621184157.GB918146@ravnborg.org>
2021-06-22 18:36 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c15947bb1566f176a2f534c52a7c3183@codeaurora.org \
--to=rajeevny@codeaurora.org \
--cc=a.hajda@samsung.com \
--cc=abhinavk@codeaurora.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hoegsberg@chromium.org \
--cc=jani.nikula@intel.com \
--cc=jingoohan1@gmail.com \
--cc=kalyan_t@codeaurora.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).