From: Keqian Zhu <zhukeqian1@huawei.com>
To: Gavin Shan <gshan@redhat.com>, <kvmarm@lists.cs.columbia.edu>
Cc: <maz@kernel.org>, <will@kernel.org>,
<linux-kernel@vger.kernel.org>, <shan.gavin@gmail.com>
Subject: Re: [PATCH 1/4] KVM: arm64: Hide kvm_mmu_wp_memory_region()
Date: Mon, 15 Mar 2021 15:49:02 +0800 [thread overview]
Message-ID: <c16969db-480e-3229-9d90-a62a0f7d8a2a@huawei.com> (raw)
In-Reply-To: <20210315041844.64915-2-gshan@redhat.com>
Hi Gavin,
This function is only used by mmu.c in the first commit c64735554c0a, so please feel free
to add:
Reviewed-by: Keqian Zhu <zhukeqian1@huawei.com>
Thanks,
Keqian
On 2021/3/15 12:18, Gavin Shan wrote:
> We needn't expose the function as it's only used by mmu.c.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> arch/arm64/include/asm/kvm_host.h | 1 -
> arch/arm64/kvm/mmu.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index 3d10e6527f7d..688f2df1957b 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -632,7 +632,6 @@ void kvm_arm_resume_guest(struct kvm *kvm);
> })
>
> void force_vm_exit(const cpumask_t *mask);
> -void kvm_mmu_wp_memory_region(struct kvm *kvm, int slot);
>
> int handle_exit(struct kvm_vcpu *vcpu, int exception_index);
> void handle_exit_early(struct kvm_vcpu *vcpu, int exception_index);
> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> index 77cb2d28f2a4..84e70f953de6 100644
> --- a/arch/arm64/kvm/mmu.c
> +++ b/arch/arm64/kvm/mmu.c
> @@ -555,7 +555,7 @@ static void stage2_wp_range(struct kvm_s2_mmu *mmu, phys_addr_t addr, phys_addr_
> * Acquires kvm_mmu_lock. Called with kvm->slots_lock mutex acquired,
> * serializing operations for VM memory regions.
> */
> -void kvm_mmu_wp_memory_region(struct kvm *kvm, int slot)
> +static void kvm_mmu_wp_memory_region(struct kvm *kvm, int slot)
> {
> struct kvm_memslots *slots = kvm_memslots(kvm);
> struct kvm_memory_slot *memslot = id_to_memslot(slots, slot);
>
next prev parent reply other threads:[~2021-03-15 7:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 4:18 [PATCH 0/4] KVM: arm64: Minor page fault handler improvement Gavin Shan
2021-03-15 4:18 ` [PATCH 1/4] KVM: arm64: Hide kvm_mmu_wp_memory_region() Gavin Shan
2021-03-15 7:49 ` Keqian Zhu [this message]
2021-03-15 4:18 ` [PATCH 2/4] KVM: arm64: Use find_vma_intersection() Gavin Shan
2021-03-15 8:04 ` Keqian Zhu
2021-03-15 9:42 ` Gavin Shan
2021-03-16 3:52 ` Gavin Shan
2021-03-16 4:20 ` Keqian Zhu
2021-03-15 8:52 ` Marc Zyngier
2021-03-15 9:40 ` Gavin Shan
2021-03-15 4:18 ` [PATCH 3/4] KVM: arm64: Fix address check for memory slot Gavin Shan
2021-03-15 7:33 ` Keqian Zhu
2021-03-15 9:46 ` Gavin Shan
2021-03-15 4:18 ` [PATCH 4/4] KVM: arm64: Don't retrieve memory slot again in page fault handler Gavin Shan
2021-03-15 8:25 ` Keqian Zhu
2021-03-15 9:56 ` Gavin Shan
2021-03-15 10:46 ` Keqian Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c16969db-480e-3229-9d90-a62a0f7d8a2a@huawei.com \
--to=zhukeqian1@huawei.com \
--cc=gshan@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).