From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbcFVOrE (ORCPT ); Wed, 22 Jun 2016 10:47:04 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:23963 "EHLO ausxipps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbcFVOrC (ORCPT ); Wed, 22 Jun 2016 10:47:02 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=jgcpzTphy7zUNJNm4DY/rtsu9lftFKiAO5XrzsL9jtQo7fHpCVdDSRFf UlxwJr+UT4VP2BiKiFFVWPCBO0IHtIn+dohCn8G2X/lhst8KHObpIdARu rmxtgNdaXbz9/9AckH8GOInW+cmIoFQUWnlZ4eYDkB1jEymJkhNThdGGY E=; X-LoopCount0: from 10.175.216.251 X-IronPort-AV: E=Sophos;i="5.26,509,1459832400"; d="scan'208";a="809235402" From: To: , CC: , , , , , , Subject: RE: [PATCH 3/4] dell-wmi: Add information about other WMI event codes Thread-Topic: [PATCH 3/4] dell-wmi: Add information about other WMI event codes Thread-Index: AQHRtB42hzf3HHxGtEu99Pj4tlzQap/MILSAgBLrjQCAACDR8IAApAwAgAuY+oCACRdL8IABITwAgAAJTLCAAF/ugP//rahwgABZ2oD//609sA== Date: Wed, 22 Jun 2016 14:46:40 +0000 Message-ID: References: <1463916983-12562-1-git-send-email-pali.rohar@gmail.com> <01b8e172bca546728b596c8cc4ebd932@ausx13mpc124.AMER.DELL.COM> <0d5a8762-b849-41c6-bfe5-e00da25d26d5@gmail.com> <201606152151.07407@pali> <20160622075602.GA29844@pali> <41f11bb2917349919e0b4eb21fab9a46@ausx13mpc124.AMER.DELL.COM> <20160622141239.GG29844@pali> <20d89b56-7633-e695-ef6e-b5a2698184d0@gmail.com> In-Reply-To: <20d89b56-7633-e695-ef6e-b5a2698184d0@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.208.89.195] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u5MEl9Yu010531 > -----Original Message----- > From: Gabriele Mazzotta [mailto:gabriele.mzt@gmail.com] > Sent: Wednesday, June 22, 2016 9:40 AM > To: Limonciello, Mario ; pali.rohar@gmail.com > Cc: mjg59@srcf.ucam.org; dvhart@infradead.org; kernel@kempniu.pl; > luto@kernel.org; alex.hung@canonical.com; platform-driver- > x86@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event > codes > > On 22/06/2016 16:21, Mario_Limonciello@Dell.com wrote: > >> -----Original Message----- > >> From: Pali Rohár [mailto:pali.rohar@gmail.com] > >> Sent: Wednesday, June 22, 2016 9:13 AM > >> To: Limonciello, Mario > >> Cc: gabriele.mzt@gmail.com; mjg59@srcf.ucam.org; > dvhart@infradead.org; > >> kernel@kempniu.pl; luto@kernel.org; alex.hung@canonical.com; > platform- > >> driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI > event > >> codes > >> > >> On Wednesday 22 June 2016 13:40:57 Mario_Limonciello@Dell.com > wrote: > >>>>> You aren't seeing this on the DSDT of your Latitude right? > >>>> > >>>> Yes, I do not see it on Latitude. > >>> > >>> Thanks, the usage of this scan code is specific to consumer BIOSes. > >>> > >>>> > >>>>> Gabriele, > >>>>> > >>>>> Your machine is from the year before XPS switched over to running > the > >>>>> Dell business client (eg Latitude, Precision, Optiplex) BIOS. > >>>>> > >>>>> The EC in that machine does have support for "Battery Health" via that > >>>>> scancode. On Windows it's used for relaying battery information to an > >>>>> application called Quick Set. > >>>> > >>>> Do you have some details when it is send to OS? And how to read that > >> that > >>>> "battery health"? > >>> > >>> When a battery is removed or inserted this event is supposed to be > >> received > >>> by quickset over WMI and then Quickset will re-read battery > information. > >> > >> So event is sent only if battery is removed or inserted? > >> > > > > Yeah, that's what my spec says, I haven't tested this on actual system to > see. > > > > I'm guessing what's going on is that during suspend ACPI battery drops > > off system and comes back up on resume. > > > > Maybe Gabriele can comment if any other times were noticed, but in any > > case I think it's appropriate for dell-wmi driver when receiving this on WMI > > to not do anything. Sending KEY_BATTERY would be wrong behavior. > > I think I saw the event only after resume, but I don't read my dmesg > that often to notice other special cases. Surely it's not related to > any hotkey nor actual battery removal. > > FYI I have a "battery button" and the associated code is 0xe007. I > guess most of the laptop nowadays use that code for QuickSet, given > that the entry for it was added to dell-wmi.c back in 2009. Ah yes to make sure that's clear - that battery button is "Battery Health Meter". For QuickSet that function was for just showing a little popup with remaining battery life. For Linux I do think KEY_BATTERY is still appropriate there. > > I would also like to remind that my laptop receives four WMI events > with code 0xe00e after resume. If we send an input event for each > WMI event with code 0xe00e, I'd get four bogus button keypresses. Yep, exactly why dell-wmi should just ignore this code.