From: Jiri Slaby <jslaby@suse.cz>
To: 唐彬 <tangbin@cmss.chinamobile.com>, gregkh <gregkh@linuxfoundation.org>
Cc: linux-serial <linux-serial@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tty:serial:mvebu-uart:fix a wrong return
Date: Wed, 4 Mar 2020 11:07:00 +0100 [thread overview]
Message-ID: <c179b76e-a597-3e5f-8e79-20deb62a9423@suse.cz> (raw)
In-Reply-To: <202003041737399757401@cmss.chinamobile.com>
On 04. 03. 20, 10:37, 唐彬 wrote:
> I'm very happy for your replay. But I don't understand, in this
> place ,it's function is to judge.You say 'the probe function is expected
> to return a negative value in case of error'？But at the top or bottom
> of the code here in mvebu_uart_probe()，there are a lot of judgments
> that return negative numbers. How do you explain that?
That's exactly the point. The function should return a negative value
and PTR_ERR already returns a negative.
That is, your patch is correct, but your commit message missed an
explanation.
thanks,
--
js
suse labs
prev parent reply other threads:[~2020-03-04 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 7:13 [PATCH 2/2] tty:serial:mvebu-uart:fix a wrong return tangbin
2020-03-03 7:57 ` Jiri Slaby
[not found] ` <202003041737399757401@cmss.chinamobile.com>
2020-03-04 10:07 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c179b76e-a597-3e5f-8e79-20deb62a9423@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).