From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C183C4743C for ; Mon, 14 Jun 2021 16:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAA49610A2 for ; Mon, 14 Jun 2021 16:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234973AbhFNQrt (ORCPT ); Mon, 14 Jun 2021 12:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233492AbhFNQrs (ORCPT ); Mon, 14 Jun 2021 12:47:48 -0400 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 646CDC061574 for ; Mon, 14 Jun 2021 09:45:45 -0700 (PDT) Received: by mail-oo1-xc29.google.com with SMTP id n17-20020a4ae1d10000b029024a49ea822bso2800593oot.5 for ; Mon, 14 Jun 2021 09:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PFSRmp8JKTSq2aEG0094DvugKBOda8AdaRxBNubaTys=; b=KgD39h1HjXt/ebnoAuXPxq3c2WU46s43ejAz2HDZX7yR3/teArjfZ3uNpnoGuOeDuA JXJ45b12d6ILvZCnpTQjkhNFAYYOwabWL+kNbIeirF2RjOyg81uKl4OOj3q//zR4HLFz zFNlZRAJnXwIKR1/t9z9LuAVdLHqz38WMRMQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PFSRmp8JKTSq2aEG0094DvugKBOda8AdaRxBNubaTys=; b=UBgJI162UWoDuco7PTMljU9J8EjV/dhY/XsRjkCH+l8JtQrGqElQEgdeu3fifYlB8D yUGuyhnZECisvBVNjgDaZPXRVUGaf97Zoz0aYA2g2/iLUVekE36P+GAcSw56jMXKM6gx TPSyHUABj12iFOIrTJlNCJKvPv3jjEgCTZ1gOa66H7zpA62lWNcBiLt+TulYEJ0bmDFl lzSZnt/zQAxxztJopykiYoSYv+qwNQPSNo/+NuolGIiwIQHqX61x846W/MFAqI2FW2+0 Ox6c3k7RN04v54pnH1qEl2n0IpC5hU6Wq55qVRM6cNRHw8hD7xZnIPFjQFdKo58AYA8v engw== X-Gm-Message-State: AOAM531D3UfZpCeUqkNtpywDcP/mjoV+e8WkHkt6Ebks2m0XODvLga+6 LtnruzwzmyTu93eVdMCXgygPsw== X-Google-Smtp-Source: ABdhPJzNffNtbA5YBzkOiXlPRc7yVP3MO7ZyIGJJfvUK2X+q/StJjff0bpIYpjn33GPrU8GyTzUu5Q== X-Received: by 2002:a4a:91cb:: with SMTP id e11mr2229118ooh.53.1623689144764; Mon, 14 Jun 2021 09:45:44 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 2sm3359048ota.58.2021.06.14.09.45.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 09:45:44 -0700 (PDT) Subject: Re: [PATCH v8 3/5] selftests/sgx: Dump enclave memory map To: Jarkko Sakkinen Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-sgx@vger.kernel.org, Reinette Chatre , Dave Hansen , linux-kernel@vger.kernel.org, Shuah Khan References: <20210610083021.392269-1-jarkko@kernel.org> <20210610083021.392269-3-jarkko@kernel.org> <20210612042723.vp26eafhyzrv7t66@kernel.org> From: Shuah Khan Message-ID: Date: Mon, 14 Jun 2021 10:45:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210612042723.vp26eafhyzrv7t66@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/11/21 10:27 PM, Jarkko Sakkinen wrote: > On Fri, Jun 11, 2021 at 04:45:19PM -0600, Shuah Khan wrote: >> On 6/10/21 2:30 AM, Jarkko Sakkinen wrote: >>> Often, it's useful to check whether /proc/self/maps looks sane when >>> dealing with memory mapped objects, especially when they are JIT'ish >>> dynamically constructed objects. Therefore, dump "/dev/sgx_enclave" >>> matching lines from the memory map in FIXTURE_SETUP(). >>> >>> Signed-off-by: Jarkko Sakkinen >>> --- >>> tools/testing/selftests/sgx/main.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/tools/testing/selftests/sgx/main.c b/tools/testing/selftests/sgx/main.c >>> index 6da19b6bf287..14030f8b85ff 100644 >>> --- a/tools/testing/selftests/sgx/main.c >>> +++ b/tools/testing/selftests/sgx/main.c >>> @@ -117,6 +117,8 @@ FIXTURE_SETUP(enclave) >>> Elf64_Sym *sgx_enter_enclave_sym = NULL; >>> struct vdso_symtab symtab; >>> struct encl_segment *seg; >>> + char maps_line[256]; >>> + FILE *maps_file; >>> unsigned int i; >>> void *addr; >>> @@ -167,6 +169,18 @@ FIXTURE_SETUP(enclave) >>> memset(&self->run, 0, sizeof(self->run)); >>> self->run.tcs = self->encl.encl_base; >>> + maps_file = fopen("/proc/self/maps", "r"); >> >> I almost applied these. Does this require root access, if so, >> please add logic to skip the test if non-root user runs it. >> >> Same comments for all other paths that might require root access. > > As Dave stated, it does not. A process can inspect its own state > through /proc/self path. E.g. Chrome web browser uses /proc/self/exe > to initialize multiple instances of itself for browser tabs... > Ah yes. I missed the self part. Thanks for clarifying. > As far as other things go, this patch set does not bind to any other > new OS resources. > Thank you. I will apply these for 5.14-rc1. thanks, -- Shuah