From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 033E7C35E01 for ; Tue, 25 Feb 2020 16:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C78CA21744 for ; Tue, 25 Feb 2020 16:21:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Kz5vmBt0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730741AbgBYQVf (ORCPT ); Tue, 25 Feb 2020 11:21:35 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:55338 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728051AbgBYQVf (ORCPT ); Tue, 25 Feb 2020 11:21:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=J3p3P1Xs0O9vBplWiDfg1XuROWQome6tzfHEzwiApJU=; b=Kz5vmBt0G2YWRfEPqm9mUBVMss cPiRtJ23JAwKdJiDWEcQn6d9h7UzBhbjjgDJPBXzpxPD5zPKnkixFabpBou2UJGkwQgOMDFvX432+ Jy0ogOtBMxdji+YUDDm4EREXv5uLplk7GBPmOYpM+JQwTauVHYCUovkLaUV+7DbnKbN3gDgIU0f4I lohHkNFlNlsdqekU+IG+wMdRQWgYVVGlZ0CwscvUWxDO8ITwsrWA7uL7NNOo+dB2Ru/AnYeTD6Rwn WVS6KlYp7cyECY4cbvgwFXRwQ+ccyRBY6iMychwLSb2vvFzHr4nDnPelXTtgxC0u4N2aaiDaPb3k7 r40hwkmQ==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6cxi-0003cc-4t; Tue, 25 Feb 2020 16:21:34 +0000 Subject: Re: [PATCH v4 9/9] power: supply: Support ROHM bd99954 charger To: Matti Vaittinen , mazziesaccount@gmail.com Cc: Sebastian Reichel , Rob Herring , Mark Rutland , Greg Kroah-Hartman , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Laine , Mikko Mutanen References: <529dd6298be245051f333ab4d9264902bf889aa6.1582617178.git.matti.vaittinen@fi.rohmeurope.com> From: Randy Dunlap Message-ID: Date: Tue, 25 Feb 2020 08:21:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <529dd6298be245051f333ab4d9264902bf889aa6.1582617178.git.matti.vaittinen@fi.rohmeurope.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/20 12:55 AM, Matti Vaittinen wrote: > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index 8781c674ed07..0b3bad6fc736 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -702,6 +702,16 @@ config CHARGER_BD70528 > information and altering charger configurations from charger > block of the ROHM BD70528 Power Management IC. > Hi, > +config CHARGER_BD99954 > + tristate "ROHM bd99954 charger driver" > + depends on I2C > + select LINEAR_RANGES > + default n Drop the "default n", since it is already the default. > + help > + Say Y here to enable support for getting battery and charger > + information and altering charger configurations from the ROHM > + BD99954 charger IC. Please indent the 3 lines of help text with one additional space (2 total). See Documentation/process/coding-style.rst: 10) Kconfig configuration files ------------------------------- For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. Example:: config AUDIT bool "Auditing support" depends on NET help Enable auditing infrastructure that can be used with another kernel subsystem, such as SELinux (which requires this for logging of avc messages output). Does not do system-call auditing without CONFIG_AUDITSYSCALL. > + > config CHARGER_WILCO > tristate "Wilco EC based charger for ChromeOS" > depends on WILCO_EC thanks. -- ~Randy