From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4737C10DCE for ; Sun, 8 Mar 2020 22:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AD43206D5 for ; Sun, 8 Mar 2020 22:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgCHWGm (ORCPT ); Sun, 8 Mar 2020 18:06:42 -0400 Received: from smtprelay0154.hostedemail.com ([216.40.44.154]:35758 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726346AbgCHWGl (ORCPT ); Sun, 8 Mar 2020 18:06:41 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 855015DE6; Sun, 8 Mar 2020 22:06:40 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wash33_1d0ce4d7d731c X-Filterd-Recvd-Size: 2123 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Sun, 8 Mar 2020 22:06:39 +0000 (UTC) Message-ID: Subject: Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough; From: Joe Perches To: "Gustavo A. R. Silva" , Andrew Morton , linux-kernel@vger.kernel.org Cc: clang-built-linux@googlegroups.com Date: Sun, 08 Mar 2020 15:05:00 -0700 In-Reply-To: <6a48e37a-a377-c9c8-3de8-c183b27cec46@embeddedor.com> References: <576fe2ab-7937-4698-b32a-8599813d6ad1@embeddedor.com> <4304de54a44b7c8c22d8c2d9249d716664cf5ce8.camel@perches.com> <6773b7e3-8ce4-55d1-8bb7-bde6d9f6e887@embeddedor.com> <259f405155a948f90229d3fc8cad928d434b46f9.camel@perches.com> <1f71509d-6c58-412d-a817-45b1cc78c06e@embeddedor.com> <18d7df753cb90d6c6f5a6b5e2a12b4c102ac8749.camel@perches.com> <7a0a3e7b-9c76-22f8-8dbf-acd9960d7950@embeddedor.com> <6a48e37a-a377-c9c8-3de8-c183b27cec46@embeddedor.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-03-08 at 17:04 -0500, Gustavo A. R. Silva wrote: > > The point is: will you update your patch so it doesn't remove > existing blank lines from the code? No. In the first place, I believe what I did is the preferred style You need to look at the code and see what you think needs to be done and then do it instead of merely sending a fairly pointless nak when in fact you can't really nak it. You could reasonably object to it, but you aren't really a listed maintainer of any subsystem and you don't have an upstream tree that is being pulled by anyone. I believe it would not trivial to implement your desire. You are welcome to try.