linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Hankland <ehankland@google.com>
Cc: Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix perfctr WRMSR for running counters
Date: Sat, 1 Feb 2020 19:51:40 +0100	[thread overview]
Message-ID: <c1cec3c8-570f-d824-cb20-6641cf686981@redhat.com> (raw)
In-Reply-To: <CAOyeoRVaV3Dh=M4ioiT3DU+p5ZnQGRcy9_PssJZ=a36MhL-xHQ@mail.gmail.com>

On 30/01/20 02:09, Eric Hankland wrote:
> Sorry - I forgot to switch to plain text mode on my first reply.
> 
>> I think this best written as it was before commit 2924b52117:
>>
>>                         if (!msr_info->host_initiated)
>>                                 data = (s64)(s32)data;
>>                         pmc->counter += data - pmc_read_counter(pmc);
> Sounds good to me.
> 
>> Do you have a testcase?
> I added a testcase to kvm-unit-tests/x86/pmu.c that fails without this
> patch and passes with it. Should I send out that patch now?

Yes, please send it!  Thanks,

Paolo


  reply	other threads:[~2020-02-01 18:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 21:22 [PATCH] KVM: x86: Fix perfctr WRMSR for running counters Eric Hankland
2020-01-28 21:59 ` Jim Mattson
2020-01-29 10:36 ` Paolo Bonzini
2020-01-30  1:09   ` Eric Hankland
2020-02-01 18:51     ` Paolo Bonzini [this message]
2020-02-07 22:15       ` Eric Hankland
2020-02-12 12:03         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1cec3c8-570f-d824-cb20-6641cf686981@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehankland@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pshier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).