From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8ECECA9EBC for ; Fri, 25 Oct 2019 22:28:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B40820663 for ; Fri, 25 Oct 2019 22:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="KHiPpw6d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbfJYW2i (ORCPT ); Fri, 25 Oct 2019 18:28:38 -0400 Received: from linux.microsoft.com ([13.77.154.182]:41486 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbfJYW2h (ORCPT ); Fri, 25 Oct 2019 18:28:37 -0400 Received: from [10.137.112.111] (unknown [131.107.147.111]) by linux.microsoft.com (Postfix) with ESMTPSA id CEB0B2010AC6; Fri, 25 Oct 2019 15:28:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CEB0B2010AC6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1572042516; bh=V6ZSkzy97Ph9Iz78UInOh5o3ydNZF/8k2BxCyvk6lyQ=; h=Subject:To:References:From:Date:In-Reply-To:From; b=KHiPpw6dkWKNFofkiya6TL+ZsFpP4nBwS4CyMT4p+8dAJR7wh56P63jvGCra7uDmP uoop4pQgCcZztR0hto1QHsJg1K1yHQzXiiowcK+YFuYA/qPG8V19d/ItFH94Rn+8vb BtJVzxKRY4VfGbqn8hlB5Yp0Ll4AcWQ/wuxWfh8c= Subject: Re: [PATCH v2 1/4] KEYS: Defined an ima hook for measuring keys on key create or update To: Mimi Zohar , dhowells@redhat.com, casey@schaufler-ca.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org References: <20191023233950.22072-1-nramas@linux.microsoft.com> <20191023233950.22072-2-nramas@linux.microsoft.com> <1572032428.4532.72.camel@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: Date: Fri, 25 Oct 2019 15:28:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <1572032428.4532.72.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/2019 12:40 PM, Mimi Zohar wrote: >> +void ima_post_key_create_or_update(struct key *keyring, struct key *key, >> + unsigned long flags, bool create) >> +{ >> + const struct public_key *pk; >> + >> + if (key->type != &key_type_asymmetric) >> + return; >> + >> + if (!ima_initialized) >> + return; > > There's no reason to define a new variable to determine if IMA is > initialized.  Use ima_policy_flag. Please correct me if I am wrong - ima_policy_flag will be set to 0 if IMA is not yet initialized OR IMA is initialized, but ima_policy_flag could be still set to 0 (say, due to the configured policy). In the latter case the measurement request should be a NOP immediately. -lakshmi