From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964956AbcIVQ5r (ORCPT ); Thu, 22 Sep 2016 12:57:47 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:38980 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933550AbcIVQ5q (ORCPT ); Thu, 22 Sep 2016 12:57:46 -0400 Subject: Re: [PATCH 2/4] GPU-DRM-TILCDC: Return directly after a failed kfree_table_init() in tilcdc_convert_slave_node() To: SF Markus Elfring , , David Airlie , Tomi Valkeinen References: <566ABCD9.1060404@users.sourceforge.net> <2f3f7ad7-16a0-1dfb-d073-0d993cd767ee@users.sourceforge.net> CC: LKML , , Julia Lawall From: Jyri Sarha Message-ID: Date: Thu, 22 Sep 2016 19:57:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/16 11:32, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 22 Sep 2016 09:29:23 +0200 > > Return directly after a memory allocation failed in this function > at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c > index 8faa28f..6204405 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c > @@ -206,7 +206,7 @@ void __init tilcdc_convert_slave_node(void) > int ret; > > if (kfree_table_init(&kft)) > - goto out; > + return; > > lcdc = of_find_matching_node(NULL, tilcdc_of_match); > slave = of_find_matching_node(NULL, tilcdc_slave_of_match); > Thanks, This is a real bug. I'll pick this up, but with your permission I change the commit subject to follow the current convention. Best regards, Jyri