From: Jens Axboe <axboe@kernel.dk>
To: Luo Jiaxing <luojiaxing@huawei.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@openeuler.org, john.garry@huawei.com,
yangxingui@huawei.com
Subject: Re: [PATCH v1] ata: ahci: Disable SXS for Hisilicon Kunpeng920
Date: Fri, 12 Mar 2021 07:27:50 -0700 [thread overview]
Message-ID: <c1ef5207-96a4-e7f1-68ac-f95ab0b0f5d2@kernel.dk> (raw)
In-Reply-To: <1615544676-61926-1-git-send-email-luojiaxing@huawei.com>
On 3/12/21 3:24 AM, Luo Jiaxing wrote:
> From: Xingui Yang <yangxingui@huawei.com>
>
> On Hisilicon Kunpeng920, ESP is set to 1 by default for all ports of
> SATA controller. In some scenarios, some ports are not external SATA ports,
> and it cause disks connected to these ports to be identified as removable
> disks. So disable the SXS capability on the software side to prevent users
> from mistakenly considering non-removable disks as removable disks and
> performing related operations.
>
> Signed-off-by: Xingui Yang <yangxingui@huawei.com>
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
> Reviewed-by: John Garry <john.garry@huawei.com>
> ---
> drivers/ata/ahci.c | 5 +++++
> drivers/ata/ahci.h | 1 +
> drivers/ata/libahci.c | 5 +++++
> 3 files changed, 11 insertions(+)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 00ba8e5..33192a8 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1772,6 +1772,11 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> hpriv->flags |= AHCI_HFLAG_NO_DEVSLP;
>
> #ifdef CONFIG_ARM64
> + if (pdev->vendor == PCI_VENDOR_ID_HUAWEI &&
> + pdev->device == 0xa235 &&
> + pdev->revision < 0x30)
> + hpriv->flags |= AHCI_HFLAG_NO_SXS;
Is this controller arm exclusive?
--
Jens Axboe
next prev parent reply other threads:[~2021-03-12 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 10:24 [PATCH v1] ata: ahci: Disable SXS for Hisilicon Kunpeng920 Luo Jiaxing
2021-03-12 14:27 ` Jens Axboe [this message]
2021-03-15 11:29 ` luojiaxing
2021-03-31 14:25 ` Jens Axboe
2021-03-31 10:26 ` luojiaxing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ef5207-96a4-e7f1-68ac-f95ab0b0f5d2@kernel.dk \
--to=axboe@kernel.dk \
--cc=john.garry@huawei.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=luojiaxing@huawei.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).