From: Jens Axboe <axboe@kernel.dk>
To: Dmitry Monakhov <dmonakhov@gmail.com>, linux-kernel@vger.kernel.org
Cc: paolo.valente@linaro.org
Subject: Re: [PATCH] block,bfq: Skip tracing hooks if possible
Date: Wed, 20 Nov 2019 16:11:03 -0700 [thread overview]
Message-ID: <c1f10727-fc7a-7ac8-545b-a3a98b06c01f@kernel.dk> (raw)
In-Reply-To: <20191101131110.18356-1-dmonakhov@gmail.com>
On 11/1/19 7:11 AM, Dmitry Monakhov wrote:
> In most cases blk_tracing is not active, but bfq_log_bfqq macro
> generate pid_str unconditionally, which result in significant overhead.
>
> ## Test
> modprobe null_blk
> echo bfq > /sys/block/nullb0/queue/scheduler
> fio --name=t --ioengine=libaio --direct=1 --filename=/dev/nullb0 \
> --runtime=30 --time_based=1 --rw=write --iodepth=128 --bs=4k
>
> # Results
> | | baseline | w/ patch | gain |
> | iops | 113.19K | 126.42K | +11% |
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-11-21 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 13:11 [PATCH] block,bfq: Skip tracing hooks if possible Dmitry Monakhov
2019-11-15 6:47 ` Paolo Valente
2019-11-20 23:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1f10727-fc7a-7ac8-545b-a3a98b06c01f@kernel.dk \
--to=axboe@kernel.dk \
--cc=dmonakhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).