From: Mike Kravetz <mike.kravetz@oracle.com>
To: Michal Hocko <mhocko@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Muchun Song <songmuchun@bytedance.com>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Matthew Wilcox <willy@infradead.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/5] hugetlb: use page.private for hugetlb specific page flags
Date: Wed, 27 Jan 2021 15:01:58 -0800 [thread overview]
Message-ID: <c1feff22-115c-ea49-a720-813a86ad9922@oracle.com> (raw)
In-Reply-To: <20210127102035.GF827@dhcp22.suse.cz>
On 1/27/21 2:20 AM, Michal Hocko wrote:
> [sorry for jumping in late]
>
> On Fri 22-01-21 11:52:27, Mike Kravetz wrote:
>> As hugetlbfs evolved, state information about hugetlb pages was added.
>> One 'convenient' way of doing this was to use available fields in tail
>> pages. Over time, it has become difficult to know the meaning or contents
>> of fields simply by looking at a small bit of code. Sometimes, the
>> naming is just confusing. For example: The PagePrivate flag indicates
>> a huge page reservation was consumed and needs to be restored if an error
>> is encountered and the page is freed before it is instantiated. The
>> page.private field contains the pointer to a subpool if the page is
>> associated with one.
>
> OK, I thought the page.private was abused more than for this very
> specific case.
>
>> In an effort to make the code more readable, use page.private to contain
>> hugetlb specific page flags. These flags will have test, set and clear
>> functions similar to those used for 'normal' page flags. More importantly,
>> an enum of flag values will be created with names that actually reflect
>> their purpose.
>
> This is definitely a step into the right direction!
>
>> In this patch,
>> - Create infrastructure for hugetlb specific page flag functions
>> - Move subpool pointer to page[1].private to make way for flags
>> Create routines with meaningful names to modify subpool field
>
> This makes some sense as well. It is really important that the primary
> state is stored in the head page. The respective data can be in tail
> pages.
>
>> - Use new HPageRestoreReserve flag instead of PagePrivate
>
> Much better! Although wouldn't HPageReserve be sufficient? The flag name
> doesn't really need to tell explicitly what to do with the reserve,
> right? Or would that be too confusing?
Thanks for taking a look.
HPageReserve could be sufficient. I don't have a strong opinion and was
just trying to add as much meaning to the name as possible. If you do not
have a strong opinion, I would just leave it as is.
--
Mike Kravetz
next prev parent reply other threads:[~2021-01-27 23:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 19:52 [PATCH v3 0/5] create hugetlb flags to consolidate state Mike Kravetz
2021-01-22 19:52 ` [PATCH v3 1/5] hugetlb: use page.private for hugetlb specific page flags Mike Kravetz
2021-01-26 8:17 ` Oscar Salvador
2021-01-27 10:20 ` Michal Hocko
2021-01-27 23:01 ` Mike Kravetz [this message]
2021-01-27 10:26 ` Michal Hocko
2021-01-22 19:52 ` [PATCH v3 2/5] hugetlb: convert page_huge_active() HPageMigratable flag Mike Kravetz
2021-01-27 10:25 ` Michal Hocko
2021-01-27 23:27 ` Mike Kravetz
2021-01-22 19:52 ` [PATCH v3 3/5] hugetlb: only set HPageMigratable for migratable hstates Mike Kravetz
2021-01-26 8:20 ` Oscar Salvador
2021-01-27 10:35 ` Michal Hocko
2021-01-27 23:36 ` Mike Kravetz
2021-01-28 5:52 ` Oscar Salvador
2021-01-28 21:37 ` Andrew Morton
2021-01-28 22:00 ` Mike Kravetz
2021-01-28 22:15 ` Andrew Morton
2021-01-29 18:46 ` Mike Kravetz
2021-02-01 11:49 ` Michal Hocko
2021-02-04 1:11 ` Mike Kravetz
2021-01-22 19:52 ` [PATCH v3 4/5] hugetlb: convert PageHugeTemporary() to HPageTemporary flag Mike Kravetz
2021-01-23 3:15 ` [External] " Muchun Song
2021-01-27 10:39 ` Michal Hocko
2021-01-22 19:52 ` [PATCH v3 5/5] hugetlb: convert PageHugeFreed to HPageFreed flag Mike Kravetz
2021-01-27 10:41 ` Michal Hocko
2021-01-27 23:37 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1feff22-115c-ea49-a720-813a86ad9922@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).