From: Geliang Tang <geliangtang@163.com>
To: Matt Fleming <matt@codeblueprint.co.uk>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>
Cc: Geliang Tang <geliangtang@163.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()
Date: Sat, 7 Nov 2015 12:43:48 +0800 [thread overview]
Message-ID: <c203e0cfee351d6f97c6a1a42c3e25b4be339f93.1446869434.git.geliangtang@163.com> (raw)
In-Reply-To: <cover.1446869434.git.geliangtang@163.com>
In-Reply-To: <337377a3fbcf855d6a5217e06fcd8c8a979f2853.1446869434.git.geliangtang@163.com>
The original efivars_pstore_exit() is empty. I
1) add a bufsize check statement.
2) call pstore_unregister as it is defined now.
3) free the memory and set bufsize to 0.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
drivers/firmware/efi/efi-pstore.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index eac76a7..62d57d8 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void)
static __exit void efivars_pstore_exit(void)
{
+ if (!efi_pstore_info.bufsize)
+ return;
+
+ pstore_unregister(&efi_pstore_info);
+ kfree(efi_pstore_info.buf);
+ efi_pstore_info.buf = NULL;
+ efi_pstore_info.bufsize = 0;
}
module_init(efivars_pstore_init);
--
2.5.0
next prev parent reply other threads:[~2015-11-07 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 4:43 [PATCH v2 0/3] pstore: resend three patches Geliang Tang
2015-11-07 4:43 ` [PATCH v2 1/3] pstore: check PSTORE_FLAGS_FRAGILE in pstore_unregister Geliang Tang
2015-11-07 4:43 ` Geliang Tang [this message]
2015-11-07 4:43 ` [PATCH v2 3/3] pstore: drop file opened reference count Geliang Tang
2015-11-11 16:59 ` [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() Matt Fleming
2015-11-11 23:08 ` Kees Cook
2015-11-11 23:23 ` Luck, Tony
2015-11-11 23:24 ` Kees Cook
2016-06-02 7:26 ` Geliang Tang, Kees Cook
2016-06-02 18:26 ` Kees Cook
2015-11-12 12:22 ` Matt Fleming
2016-06-02 18:17 ` [PATCH v2 1/3] pstore: check PSTORE_FLAGS_FRAGILE in pstore_unregister Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c203e0cfee351d6f97c6a1a42c3e25b4be339f93.1446869434.git.geliangtang@163.com \
--to=geliangtang@163.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).