From: Tero Kristo <t-kristo@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
Richard Watts <rrw@kynesim.co.uk>, <linux-omap@vger.kernel.org>,
<linux-clk@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: ti: fix linker error with !SOC_OMAP4
Date: Thu, 20 Apr 2017 18:13:50 +0300 [thread overview]
Message-ID: <c20456ea-dee2-878a-6cf1-2b3169fd20f4@ti.com> (raw)
In-Reply-To: <CAK8P3a2=pDP7-b4njRo9KKa-JAueTp8O=stmyMz68-Piy__UKQ@mail.gmail.com>
On 20/04/17 18:06, Arnd Bergmann wrote:
> On Thu, Apr 20, 2017 at 4:57 PM, Tero Kristo <t-kristo@ti.com> wrote:
>> On 20/04/17 00:43, Arnd Bergmann wrote:
>>>
>>> When none of the OMAP4-generation SoCs are enabled, we run into a link
>>> error for am43xx/am43xx:
>>>
>>> drivers/clk/ti/dpll.o: In function `of_ti_am3_dpll_x2_setup':
>>> dpll.c:(.init.text+0xd8): undefined reference to `clkhwops_omap4_dpllmx'
>>>
>>> This is easily fixed by adding another #ifdef.
>>>
>>> While looking at the code, I also spotted another problem with the
>>> assignment of hw_ops variable that is not used again later. I'm
>>> changing this to setting clk_hw->ops instead, which I guess is what
>>> was intended here.
>>
>>
>> Good catch... It seems the corner case is masked in the testing I did
>> locally so far.
>>
>>>
>>> Fixes: 0565fb168d63 ("clk: ti: dpll: move omap3 DPLL functionality to
>>> clock driver")
>>
>>
>> However, I believe the fixes tag should point to this one in linux-next:
>>
>> commit 473adbf4e02857a6b78dfb3d9fcf752638bbadb9
>> Author: Tero Kristo <t-kristo@ti.com>
>> Date: Thu Feb 9 11:25:28 2017 +0200
>>
>> clk: ti: dpll44xx: fix clksel register initialization
>
> Ah, right.
>
>> Other than that:
>>
>> Acked-by: Tero Kristo <t-kristo@ti.com>
>
> Do you want me to resend, or can you forward the patch with the
> fixed fixes line?
I guess thats up to Stephen, he typically picks single fixes like these.
I can also create a pull request with the fixes you provided if Stephen
prefers that, in that case I can fix the "Fixes:" tag myself.
Stephen any preference?
-Tero
PS: I'm still checking the other two patches you provided, as they are
more complex than this one.
next prev parent reply other threads:[~2017-04-20 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 21:43 [PATCH] clk: ti: fix linker error with !SOC_OMAP4 Arnd Bergmann
2017-04-20 14:57 ` Tero Kristo
2017-04-20 15:06 ` Arnd Bergmann
2017-04-20 15:13 ` Tero Kristo [this message]
2017-04-22 1:54 ` Stephen Boyd
2017-04-22 1:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c20456ea-dee2-878a-6cf1-2b3169fd20f4@ti.com \
--to=t-kristo@ti.com \
--cc=arnd@arndb.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rrw@kynesim.co.uk \
--cc=sboyd@codeaurora.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).