From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF05DC433DB for ; Fri, 29 Jan 2021 16:53:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B53160234 for ; Fri, 29 Jan 2021 16:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231761AbhA2Qxm (ORCPT ); Fri, 29 Jan 2021 11:53:42 -0500 Received: from mleia.com ([178.79.152.223]:51854 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231582AbhA2Qwy (ORCPT ); Fri, 29 Jan 2021 11:52:54 -0500 Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 40D8742F998; Fri, 29 Jan 2021 16:51:56 +0000 (UTC) Subject: Re: [PATCH] pwm: fix semicolon.cocci warnings To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , kernel test robot , kbuild-all@lists.01.org, Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Thierry Reding , Martin Blumenstingl , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <202101282111.dfwxyPwI-lkp@intel.com> <20210128134537.GA54687@068c7b848bbb> <20210128205716.j2afd32lcxh2l323@pengutronix.de> From: Vladimir Zapolskiy Message-ID: Date: Fri, 29 Jan 2021 18:51:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210128205716.j2afd32lcxh2l323@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20210129_165156_288101_1C25B468 X-CRM114-Status: GOOD ( 12.07 ) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/28/21 10:57 PM, Uwe Kleine-König wrote: > Hello, > > On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote: >> From: kernel test robot >> >> drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon >> >> >> Remove unneeded semicolon. >> >> Generated by: scripts/coccinelle/misc/semicolon.cocci >> >> Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers") > > This looks wrong. e96c0ff4b1e0 only touches drivers/pwm/Kconfig. > > The ; was introduced by commit 841e6f90bb78 ("pwm: NXP LPC18xx PWM/SCT > driver") Right, thank you for the correction, Uwe. Since the patch has been composed by the robot, it has to be fixed in the first place. And regarding this particular change and in general fixes to this type of issues detected by the robot, I don't think that it earns a Fixes tag. >> CC: Krzysztof Kozlowski >> Reported-by: kernel test robot >> Signed-off-by: kernel test robot -- Best wishes, Vladimir