From: Tom Lendacky <thomas.lendacky@amd.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: "Joerg Roedel" <joro@8bytes.org>,
"Borislav Petkov" <bp@alien8.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v3 0/2] KVM: MSR-based features
Date: Mon, 26 Feb 2018 12:32:30 -0600 [thread overview]
Message-ID: <c2194502-4326-3c7a-27c5-eb6c0d82b8f5@amd.com> (raw)
In-Reply-To: <cb405817-0bc5-fdea-baa7-e11e4a7a4163@redhat.com>
On 2/23/2018 5:38 PM, Paolo Bonzini wrote:
> On 21/02/2018 20:39, Tom Lendacky wrote:
>> The following series implements support within KVM for MSR-based features.
>> The first patch creates the MSR-based feature framework used to retrieve
>> the available MSR-based features. The second patch makes use of the
>> framework to allow a guest to determine if the LFENCE instruction is
>> serializing on AMD processors.
>>
>> This series is based on the master branch of the KVM git tree.
>>
>> https://git.kernel.org/pub/scm/virt/kvm/kvm.git
>
> I made a couple adjustments:
>
> - use a system (/dev/kvm) ioctl, which unfortunately means a new ioctl
> #define but is more consistent with KVM_GET_SUPPORTED_CPUID and
> KVM_GET_MSR_INDEX_LIST
>
> - rename msr_feature to get_msr_feature
>
> Please take a look at kvm/queue! Thanks,
Looks good to me. Just some documentation nits. You have an extra "S" in
the documentation for KVM_GET_MSR_FEATURES_INDEX_LIST vs what is in the
code, KVM_GET_MSR_FEATURE_INDEX_LIST. Also you have "vm ioctl" listed
under 4.3 (KVM_GET_MSR_INDEX_LIST, KVM_GET_MSR_FEATURE_INDEX_LIST) which
isn't valid anymore.
Otherwise, tested and works fine.
Thanks,
Tom
>
> Paolo
>
>> ---
>>
>> Changes from v2:
>> - Moved back to initializing the MSR-based feature list in kvm_init_msr_list()
>> (based on the kvm_x86_ops callback return code)
>> - Removed the definition of KVM_GET_MSR and switched back to using KVM_GET_MSRS
>> - Consolidated the documentation to group the ioctl usage and describe the usage
>> specific to the version of the ioctl used.
>>
>> Tom Lendacky (2):
>> KVM: x86: Add a framework for supporting MSR-based features
>> KVM: SVM: Add MSR-based feature support for serializing LFENCE
>>
>>
>> Documentation/virtual/kvm/api.txt | 29 +++++++++++----
>> arch/x86/include/asm/kvm_host.h | 2 +
>> arch/x86/kvm/svm.c | 43 ++++++++++++++++++++++
>> arch/x86/kvm/x86.c | 72 +++++++++++++++++++++++++++++++++++--
>> include/uapi/linux/kvm.h | 1 +
>> 5 files changed, 136 insertions(+), 11 deletions(-)
>>
>
next prev parent reply other threads:[~2018-02-26 18:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 19:39 [PATCH v3 0/2] KVM: MSR-based features Tom Lendacky
2018-02-21 19:39 ` [PATCH v3 1/2] KVM: x86: Add a framework for supporting " Tom Lendacky
2018-02-21 19:40 ` [PATCH v3 2/2] KVM: SVM: Add MSR-based feature support for serializing LFENCE Tom Lendacky
2018-02-23 23:38 ` [PATCH v3 0/2] KVM: MSR-based features Paolo Bonzini
2018-02-26 18:32 ` Tom Lendacky [this message]
2018-04-17 8:39 ` Wanpeng Li
2018-04-17 9:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2194502-4326-3c7a-27c5-eb6c0d82b8f5@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@alien8.de \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).