From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752616AbcF1PlK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 11:41:10 -0400
Received: from mout.web.de ([212.227.17.12]:53636 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752579AbcF1PlH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 11:41:07 -0400
Subject: Re: [PATCH 4/6] mfd: dm355evm_msp: Refactoring for add_child()
To: Lee Jones <lee.jones@linaro.org>
References: <566ABCD9.1060404@users.sourceforge.net>
 <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1>
 <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net>
 <de3598c4-f85a-6807-303a-55ee0ac707f2@users.sourceforge.net>
 <20160608111442.GB14888@dell>
 <e4eaf0b4-e539-b400-c8a2-70f210cee1fa@users.sourceforge.net>
 <75c1cc23-3a2d-db78-d0f2-b5934b18e828@users.sourceforge.net>
 <20160628150725.GL24982@dell>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c220895b-e56f-dc95-500d-0cf9d2f51777@users.sourceforge.net>
Date: Tue, 28 Jun 2016 17:40:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20160628150725.GL24982@dell>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:BOnaqEp4aWiK8ZvNY3Qm2fChS6NIyY1Ks/zgUba+2Z3yn/fLPrv
 Ng9Cpf28cGUlwtZFKf3CG+hiucNLtBGZosCa4/fTr+cfLEUx3jmE/KtzSMx/pfYl0tE/1sw
 UC2N/nTn3Kgq23cDSaYnkScsOC6Fn07+GUEoan2FHwibIapAEUUNdIuiICKa7UB9j22Dx3b
 os1R4xE4EORS3pusRRKGw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:C3MCqRidiMc=:i6PYJyx5j+ss1pviCGvYQf
 D43jqvB4/uzsdc9iRdrh31dCN6cjL1OTFMjdBiWi28vh/eML3ZFhcx5wylGoYcEa8SdSx8Y5Q
 KPTvcpetNRgh6Xtb6mfBqBU2y4LWWPrux023P/UhSDrUnezYvCfDSJ4NOy/shLC/xFJ/MTTEB
 UW8Bb8bSVotwSRneif2BA9FRdaPSRhK96kgreyhg32PmXRqTBX7CaftlTbobKTNJHU4fRaD/1
 fuEIKwvecVW1Y9qkWI81J2YFJ73HeSqPt4cPmf4r0z9YOg9uwXaoZkhohA81BmyvrmTARgAZe
 IgTh/fBIlWrBKCcEq71P3XoYC5JLlEHrWW1krPKVVXEszLv3NlRnRdmHrSGatjlgu6M2Z1nBd
 bDR83Qfut9zHSP1Os/VVp+N4o26/FIlMgEmBnl1vShmNq3MhqLCu0emFju0ox6KVklRiS2XuL
 mFdpoIBMR5oIlTa9mWrqbYkvWOz/Du4toep/T43KZLhnhBYhMbikPrPowkdE+ccK+heXrH0Wn
 pOoVNm6k8VdM16cpCoMsmDl3wIv7oSxdA3pIaJGsfn8mh2cI45IpYi+6SpYSXmkyoGAoLH3Xm
 axc4R2pJUdjalZ6VjBGYre498t4xUi4/Wx+d8psr6AqN5gFLl592Es+5yb9GeG+nY3IzuKOj/
 Bt7eg86TG+WOTcX1fuMb0HPSq2fniGSzNl8QZ7fT8E8tCyDf1yOW4QsAYybGPGsH2vo7whqeu
 7HoZMIQcpuU3drR2twHfIItWPCSnh8T12UJ2vn9mBBmzbuDwQd3dcwr2yELsI5RMVh04XR3Jo
 1rBb6af
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -222,19 +222,21 @@ static struct device *add_child(struct i2c_client *client, const char *name,
>>  		status = platform_device_add_resources(pdev, &r, 1);
>>  		if (status < 0) {
>>  			dev_dbg(&pdev->dev, "can't add irq\n");
>> -			goto err;
>> +			goto put_device;
>>  		}
>>  	}
>>  
>>  	status = platform_device_add(pdev);
>>  
> 
> Remove this line too.

Do you propose the deletion of a blank line here?

Did you skip this update suggestion while the other patches were finally accepted?

Regards,
Markus