From: Yunfeng Ye <yeyunfeng@huawei.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <wuxu.wu@huawei.com>, Hewenliang <hewenliang4@huawei.com>
Subject: Re: [PATCH v2 2/2] arm64: mm: Use asid feature macro for cheanup
Date: Thu, 9 Dec 2021 09:36:18 +0800 [thread overview]
Message-ID: <c222ba12-6673-0d58-fb2e-9043ce279995@huawei.com> (raw)
In-Reply-To: <0834bf48-b602-b173-63d5-381a58962b3e@huawei.com>
On 2021/12/8 17:35, Kefeng Wang wrote:
> Delete the first blank line and add your SOB,
>
Ok, thanks.
> For series,
>
> Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> On 2021/12/8 17:17, Yunfeng Ye wrote:
>> The commit 95b54c3e4c92 ("KVM: arm64: Add feature register flag
>> definitions") introduce the ID_AA64MMFR0_ASID_8 and ID_AA64MMFR0_ASID_16
>> macros.
>>
>> We can use these macros for cheanup in get_cpu_asid_bits().
>>
>> No functional change.
>> ---
>> arch/arm64/mm/context.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
>> index bbc2708fe928..b8b4cf0bcf39 100644
>> --- a/arch/arm64/mm/context.c
>> +++ b/arch/arm64/mm/context.c
>> @@ -50,10 +50,10 @@ static u32 get_cpu_asid_bits(void)
>> pr_warn("CPU%d: Unknown ASID size (%d); assuming 8-bit\n",
>> smp_processor_id(), fld);
>> fallthrough;
>> - case 0:
>> + case ID_AA64MMFR0_ASID_8:
>> asid = 8;
>> break;
>> - case 2:
>> + case ID_AA64MMFR0_ASID_16:
>> asid = 16;
>> }
>>
> .
>
next prev parent reply other threads:[~2021-12-09 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 9:16 [PATCH v2 1/2] arm64: mm: Rename asid2idx() to ctxid2asid() Yunfeng Ye
2021-12-08 9:17 ` [PATCH v2 2/2] arm64: mm: Use asid feature macro for cheanup Yunfeng Ye
2021-12-08 9:35 ` Kefeng Wang
2021-12-09 1:36 ` Yunfeng Ye [this message]
2021-12-08 18:25 ` [PATCH v2 1/2] arm64: mm: Rename asid2idx() to ctxid2asid() Catalin Marinas
2021-12-09 1:35 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c222ba12-6673-0d58-fb2e-9043ce279995@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=hewenliang4@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=wuxu.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).