From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB52C352A3 for ; Thu, 13 Feb 2020 21:01:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 670BA206B6 for ; Thu, 13 Feb 2020 21:01:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="sEQ+8hWw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbgBMVBm (ORCPT ); Thu, 13 Feb 2020 16:01:42 -0500 Received: from linux.microsoft.com ([13.77.154.182]:43008 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728028AbgBMVBl (ORCPT ); Thu, 13 Feb 2020 16:01:41 -0500 Received: from [10.137.112.97] (unknown [131.107.147.225]) by linux.microsoft.com (Postfix) with ESMTPSA id 9E23C20B9C02; Thu, 13 Feb 2020 13:01:40 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9E23C20B9C02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1581627700; bh=RlVWb6B2Yj5GqYRUZdm6taeMRNIqKiey+W202nGiIi8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=sEQ+8hWw3mCob7DpFUrzstr0mHNKXIzgk7YCHHKxnad3EuL1PSvJ4/EcAn1fifSV4 e9DBmztMMlimpTymNMkLXIKDWemAl1hmLs3FCnMQ1As1aazzoK/UalcVXqAsLWWCOK 6yf3Faot+AUezvwkOFfltihcEeoEM0ONhClB3vj4= Subject: Re: [PATCH v3 2/3] IMA: Add log statements for failure conditions. To: Mimi Zohar , joe@perches.com, skhan@linuxfoundation.org, linux-integrity@vger.kernel.org Cc: sashal@kernel.org, nramas@linux.microsoft.com, linux-kernel@vger.kernel.org References: <20200211231414.6640-1-tusharsu@linux.microsoft.com> <20200211231414.6640-3-tusharsu@linux.microsoft.com> <1581518823.8515.49.camel@linux.ibm.com> <1581553311.8515.96.camel@linux.ibm.com> From: Tushar Sugandhi Message-ID: Date: Thu, 13 Feb 2020 13:01:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1581553311.8515.96.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-02-12 4:21 p.m., Mimi Zohar wrote: > On Wed, 2020-02-12 at 14:30 -0800, Tushar Sugandhi wrote: >> >> On 2020-02-12 6:47 a.m., Mimi Zohar wrote: >>> Hi Tushar, >>> >>> Please remove the period at the end of the  Subject line. >> Thanks. I will fix it in the next iteration. >>> >>> On Tue, 2020-02-11 at 15:14 -0800, Tushar Sugandhi wrote: >>>> process_buffer_measurement() does not have log messages for failure >>>> conditions. >>>> >>>> This change adds a log statement in the above function. >>> >>> I agree some form of notification needs to be added.  The question is >>> whether the failure should be audited or a kernel message emitted. >>>  IMA emits audit messages (integrity_audit_msg) for a number of >>> reasons - on failure to calculate a file hash, invalid policy rules, >>> failure to communicate with the TPM, signature verification errors, >>> etc. >> I believe both IMA audit messages and kernel message should be emitted - >> for better discoverability and diagnosability. > > Like file measurement failures, failure to measure a key or the boot > command line should be audited as well.  For debugging purposes, you > could make this message pr_devel. Ok. I will change this to pr_devel in next iteration. > > Mimi >