From: Jason Yan <yanaijie@huawei.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: <tony@atomide.com>, <peter.ujfalusi@ti.com>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()
Date: Wed, 6 May 2020 16:43:00 +0800 [thread overview]
Message-ID: <c24dfb33-bbce-732e-c242-f4f4e6a1e04f@huawei.com> (raw)
In-Reply-To: <20200506082941.GA1559@shell.armlinux.org.uk>
在 2020/5/6 16:29, Russell King - ARM Linux admin 写道:
> On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote:
>> Fix the following coccicheck warning:
>>
>> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return
>> "0" on line 161
>
> NAK. Look closer at what the code is doing, thanks.
>
> This warning is basically incorrect.
>
OK, the macro SET_DMA_ERRATA is using this variable.
next prev parent reply other threads:[~2020-05-06 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 6:19 [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata() Jason Yan
2020-05-06 8:29 ` Russell King - ARM Linux admin
2020-05-06 8:43 ` Jason Yan [this message]
2020-05-20 7:08 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c24dfb33-bbce-732e-c242-f4f4e6a1e04f@huawei.com \
--to=yanaijie@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).