From: Robin Murphy <robin.murphy@arm.com>
To: "Andreas Färber" <afaerber@suse.de>, "James Tai" <james.tai@realtek.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-realtek-soc@lists.infradead.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH 2/2] arm64: dts: realtek: Add RTD1319 SoC and Realtek PymParticle EVB
Date: Thu, 5 Dec 2019 12:10:35 +0000 [thread overview]
Message-ID: <c2703787-2d0b-4d78-f4e3-8b77ba636bb4@arm.com> (raw)
In-Reply-To: <4040ffcf-5c54-fb44-b0a8-ce0c8c21b93f@suse.de>
On 2019-12-05 10:58 am, Andreas Färber wrote:
[...]
>> + arm_pmu: pmu {
>> + compatible = "arm,armv8-pmuv3";
>> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
>> + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>,
>> + <&cpu3>;
>> + };
>
> @Robin, is this single PPI interrupt better than previous single SPI?
Yes, a PPI is ideal (since it allows core to see its own local interrupt).
> Is "arm,armv8-pmuv3" the correct one to use for Cortex-A55? There's no
> "arm,cortex-a55-pmu" binding - is that still in the works?
Hmm, I had thought that had been done already, but apparently not. Looks
like it's high time for another round of event map updates for the
latest Cortex and Neoverse cores, so I guess I'll add that to our
backlog internally - although the PMU events should be in the public
TRMs so if anyone else *did* fancy ploughing through them to spin
patches they're always welcome to :)
In the meantime the generic PMUv3 compatible will at least expose the
subset of mandatory architectural events, which is arguably more useful
than nothing.
>> +
>> + psci {
>> + compatible = "arm,psci-1.0";
>
> @Lorenzo: Same question as left unanswered for RTD1619:
> Should this be "arm,psci-1.0", "arm-psci-0.2"?
>
> The YAML schema allows both, without clearly documenting which one shall
> be used in new DTs, and there's no psci-1.0 example either.
FWIW the age of the DT shouldn't really be relevant - it's a question of
whether the platform's EL3 firmware actually implements the PSCI 1.0 (or
later) spec, or is some fossilised binary based on the older version.
Robin.
next prev parent reply other threads:[~2019-12-05 12:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 8:25 [PATCH 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support James Tai
2019-12-05 8:25 ` [PATCH 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai
2019-12-05 8:33 ` Andreas Färber
2019-12-18 23:28 ` Rob Herring
2019-12-05 8:25 ` [PATCH 2/2] arm64: dts: realtek: Add RTD1319 SoC " James Tai
2019-12-05 10:58 ` Andreas Färber
2019-12-05 12:10 ` Robin Murphy [this message]
2019-12-27 7:17 ` James Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2703787-2d0b-4d78-f4e3-8b77ba636bb4@arm.com \
--to=robin.murphy@arm.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=james.tai@realtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).