From: John Hubbard <jhubbard@nvidia.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: <john.hubbard@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Benvenuti <benve@cisco.com>,
Christoph Hellwig <hch@infradead.org>,
Christopher Lameter <cl@linux.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Doug Ledford <dledford@redhat.com>, Jan Kara <jack@suse.cz>,
Jason Gunthorpe <jgg@ziepe.ca>,
Jerome Glisse <jglisse@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Ralph Campbell <rcampbell@nvidia.com>,
Tom Talpey <tom@talpey.com>, LKML <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions
Date: Wed, 13 Mar 2019 20:19:08 -0700 [thread overview]
Message-ID: <c29ddfcc-ce1d-f4bd-7e0d-905b6f92ecc7@nvidia.com> (raw)
In-Reply-To: <20190313144941.GA23350@iweiny-DESK2.sc.intel.com>
On 3/13/19 7:49 AM, Ira Weiny wrote:
> On Tue, Mar 12, 2019 at 05:38:55PM -0700, John Hubbard wrote:
>> On 3/12/19 8:30 AM, Ira Weiny wrote:
>>> On Wed, Mar 06, 2019 at 03:54:55PM -0800, john.hubbard@gmail.com wrote:
>>>> From: John Hubbard <jhubbard@nvidia.com>
>>>>
>>>> Introduces put_user_page(), which simply calls put_page().
>>>> This provides a way to update all get_user_pages*() callers,
>>>> so that they call put_user_page(), instead of put_page().
>>>
>>> So I've been running with these patches for a while but today while ramping up
>>> my testing I hit the following:
>>>
>>> [ 1355.557819] ------------[ cut here ]------------
>>> [ 1355.563436] get_user_pages pin count overflowed
>>
>> Hi Ira,
>>
>> Thanks for reporting this. That overflow, at face value, means that we've
>> used more than the 22 bits worth of gup pin counts, so about 4 million pins
>> of the same page...
>
> This is my bug in the patches I'm playing with. Somehow I'm causing more puts
> than gets... I'm not sure how but this is for sure my problem.
>
> Backing off to your patch set the numbers are good.
Now that's a welcome bit of good news!
>
> Sorry for the noise.
>
> With the testing I've done today I feel comfortable adding
>
> Tested-by: Ira Weiny <ira.weiny@intel.com>
>
> For the main GUP and InfiniBand patches.
>
> Ira
>
OK, I'll add your tested-by tag to patches 1, 2, 4, 5 (the numbering refers
to the "RFC v2: mm: gup/dma tracking" posting [1]) in my repo [2], and they'll
show up in the next posting. (Patch 3 is already upstream, and patch 6 is
documentation that needs to be rewritten entirely.)
[1] https://lore.kernel.org/r/20190204052135.25784-1-jhubbard@nvidia.com
[2] https://github.com/johnhubbard/linux/tree/gup_dma_core
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2019-03-14 3:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 23:54 [PATCH v3 0/1] mm: introduce put_user_page*(), placeholder versions john.hubbard
2019-03-06 23:54 ` [PATCH v3 1/1] " john.hubbard
2019-03-08 2:58 ` Christopher Lameter
2019-03-08 3:15 ` John Hubbard
2019-03-08 17:43 ` Weiny, Ira
2019-03-08 17:57 ` Jerome Glisse
2019-03-08 21:27 ` John Hubbard
2019-03-12 15:30 ` Ira Weiny
2019-03-13 0:38 ` John Hubbard
2019-03-13 14:49 ` Ira Weiny
2019-03-14 3:19 ` John Hubbard [this message]
2019-03-07 8:37 ` [PATCH v3 0/1] " Ira Weiny
2019-03-08 3:08 ` Christopher Lameter
2019-03-08 19:07 ` Jerome Glisse
2019-03-12 4:52 ` Christopher Lameter
2019-03-12 15:35 ` Jerome Glisse
2019-03-12 15:53 ` Jason Gunthorpe
2019-03-13 19:16 ` Christopher Lameter
2019-03-13 19:33 ` Jerome Glisse
2019-03-14 9:03 ` Jan Kara
2019-03-14 12:57 ` Jason Gunthorpe
2019-03-14 13:30 ` Jan Kara
2019-03-14 20:25 ` William Kucharski
2019-03-14 20:37 ` John Hubbard
2019-03-10 22:47 ` Dave Chinner
2019-03-12 5:23 ` Christopher Lameter
2019-03-12 10:39 ` Ira Weiny
2019-03-12 22:11 ` Dave Chinner
2019-03-12 15:23 ` Ira Weiny
2019-03-13 16:03 ` Christoph Hellwig
2019-03-13 19:21 ` Christopher Lameter
2019-03-14 9:06 ` Jan Kara
2019-03-18 20:12 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c29ddfcc-ce1d-f4bd-7e0d-905b6f92ecc7@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=benve@cisco.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=john.hubbard@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=rcampbell@nvidia.com \
--cc=rppt@linux.ibm.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).