From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13763C25B08 for ; Fri, 5 Aug 2022 18:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241162AbiHESZt (ORCPT ); Fri, 5 Aug 2022 14:25:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233431AbiHESZq (ORCPT ); Fri, 5 Aug 2022 14:25:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E312B26AD4 for ; Fri, 5 Aug 2022 11:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659723943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5gbZS7QF09rE8ScpjrsJlHIn7pEqxX+BCCZXbzG+bY8=; b=bmzrORyfQeRxEnEOAS1CbjieMG3wDCcL7/Nq6tnxgSFImkb0tcDulQA2AcZ17yTuEQzqfr 5Q2in+DUxwvZ9k0pjZVreFypVhccBn+mLzVkJchpiK/ybzaXo6RbIfWlmHJPLLyHNzb60V 8MlO4D5tYwp6aSGi5VcMx+wyo9axrfk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-SPbAasfQOSCIWTo-1QsLRg-1; Fri, 05 Aug 2022 14:25:40 -0400 X-MC-Unique: SPbAasfQOSCIWTo-1QsLRg-1 Received: by mail-wm1-f71.google.com with SMTP id h133-20020a1c218b000000b003a4f57eaeaaso1547595wmh.8 for ; Fri, 05 Aug 2022 11:25:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=5gbZS7QF09rE8ScpjrsJlHIn7pEqxX+BCCZXbzG+bY8=; b=X2aQ6mwDR+SZ6CBEMAQNbkYc2DEFQB79Www2DMEu3S7VD43OMumHZc9EV2QcuCi8kv 40Vsfh4pJE8X+hmc40IRwkk40UwF4/RX+iTSsgVK7n8Pr9YtRtqIg/ubGIRyfUoayB6A JX3MIYDWprTDw0Oc40W3IfMVqFluVAIGH77CoWTAs+mHNZiUJC4fUtyrUcW0iObMiwQ5 8dOspnGISVJ0DsNAVXSGVYMNTrTlEa4hhIQg8wZk6yBmdnnCpBBthb/4He/45i3MJha3 fSURnlu9H4C+ExSkUesuwYr8RckSagDAXNIgIvyXrp2Ef3ncqyAd/3BNjZGh/kZR3g6N Lc0w== X-Gm-Message-State: ACgBeo266Z3umGXekt2MidBArSC1GzGyh2JirEWaewnkZV/mF8jtTGuj 1uLLGNyTIq8asbKBJzgaNnxM0HhVNOMGxLfgguF7CYUArM3PRYeOs30ytMiSeHRd7wUY7boAlEI XlKeU7jgd5WWqTQwlpzHtoFiX X-Received: by 2002:a5d:595f:0:b0:220:619d:da07 with SMTP id e31-20020a5d595f000000b00220619dda07mr5039735wri.10.1659723939387; Fri, 05 Aug 2022 11:25:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7LHyYXq3T7uBDEmcodrtgkrkt4qPFOx+H0sFCOo3qbsgD8PcEUXT31a6r/ZIVw1aJCZtgxIQ== X-Received: by 2002:a5d:595f:0:b0:220:619d:da07 with SMTP id e31-20020a5d595f000000b00220619dda07mr5039725wri.10.1659723939149; Fri, 05 Aug 2022 11:25:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:fb00:f5c3:24b2:3d03:9d52? (p200300cbc706fb00f5c324b23d039d52.dip0.t-ipconnect.de. [2003:cb:c706:fb00:f5c3:24b2:3d03:9d52]) by smtp.gmail.com with ESMTPSA id f5-20020a5d58e5000000b0021eed2414c9sm4409875wrd.40.2022.08.05.11.25.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 11:25:38 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 20:25:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 1/2] mm/hugetlb: fix hugetlb not supporting write-notify Content-Language: en-US To: Mike Kravetz , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muchun Song , Peter Feiner , "Kirill A . Shutemov" , stable@vger.kernel.org References: <20220805110329.80540-1-david@redhat.com> <20220805110329.80540-2-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.08.22 20:23, Mike Kravetz wrote: > On 08/05/22 14:14, Peter Xu wrote: >> On Fri, Aug 05, 2022 at 01:03:28PM +0200, David Hildenbrand wrote: >>> diff --git a/mm/mmap.c b/mm/mmap.c >>> index 61e6135c54ef..462a6b0344ac 100644 >>> --- a/mm/mmap.c >>> +++ b/mm/mmap.c >>> @@ -1683,6 +1683,13 @@ int vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot) >>> if ((vm_flags & (VM_WRITE|VM_SHARED)) != ((VM_WRITE|VM_SHARED))) >>> return 0; >>> >>> + /* >>> + * Hugetlb does not require/support writenotify; especially, it does not >>> + * support softdirty tracking. >>> + */ >>> + if (is_vm_hugetlb_page(vma)) >>> + return 0; >> >> I'm kind of confused here.. you seems to be fixing up soft-dirty for >> hugetlb but here it's explicitly forbidden. >> >> Could you explain a bit more on why this patch is needed if (assume >> there'll be a working) patch 2 being provided? >> > > No comments on the patch, but ... > > Since it required little thought, I ran the test program on next-20220802 and > was surprised that the issue did not recreate. Even added a simple printk > to make sure we were getting into vma_wants_writenotify with a hugetlb vma. > We were. ... does your config have CONFIG_MEM_SOFT_DIRTY enabled? -- Thanks, David / dhildenb