From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Qin Jian <qinjian@cqplus1.com>
Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
tglx@linutronix.de, maz@kernel.org, p.zabel@pengutronix.de,
linux@armlinux.org.uk, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver
Date: Wed, 13 Apr 2022 08:37:23 +0200 [thread overview]
Message-ID: <c2a7f2e0-1a21-bb0c-9221-c184cfaa3626@linaro.org> (raw)
In-Reply-To: <f8d5675d1bc32962af6379f78a171ed35b181ebc.1649659095.git.qinjian@cqplus1.com>
On 11/04/2022 08:49, Qin Jian wrote:
> Add documentation to describe Sunplus SP7021 clock driver bindings.
(...)
> diff --git a/include/dt-bindings/clock/sp-sp7021.h b/include/dt-bindings/clock/sp-sp7021.h
> new file mode 100644
> index 000000000..de8ef5601
> --- /dev/null
> +++ b/include/dt-bindings/clock/sp-sp7021.h
> @@ -0,0 +1,90 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (C) Sunplus Technology Co., Ltd.
> + * All rights reserved.
> + */
> +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H
> +
> +#define XTAL 27000000
This looks like frequency which usually does not belong to bindings. Why
do you need it here?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-13 6:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 6:49 [PATCH v13 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-04-11 6:49 ` [PATCH v13 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-04-13 6:34 ` Krzysztof Kozlowski
2022-04-11 6:49 ` [PATCH v13 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-04-12 22:06 ` Rob Herring
2022-04-13 6:35 ` Krzysztof Kozlowski
2022-04-11 6:49 ` [PATCH v13 3/9] reset: Add Sunplus " Qin Jian
2022-04-11 6:49 ` [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-04-13 6:37 ` Krzysztof Kozlowski [this message]
2022-04-14 7:06 ` qinjian[覃健]
2022-04-14 15:18 ` Rob Herring
2022-04-11 6:49 ` [PATCH v13 5/9] clk: Add Sunplus " Qin Jian
2022-04-11 22:57 ` kernel test robot
2022-04-11 6:49 ` [PATCH v13 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-04-11 6:49 ` [PATCH v13 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-04-12 9:28 ` kernel test robot
2022-04-11 6:49 ` [PATCH v13 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-04-11 6:49 ` [PATCH v13 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2a7f2e0-1a21-bb0c-9221-c184cfaa3626@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).