From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>,
Henry Sun <henrysun@google.com>,
Bob Moragues <moragues@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel
Date: Thu, 21 Jul 2022 18:52:11 +0200 [thread overview]
Message-ID: <c2b03863-2249-13e6-98e0-731c1b40d0a9@linaro.org> (raw)
In-Reply-To: <CAD=FV=XmaNdc9k98vAwbcN-sm0w_WeqhRsK_AUm3h4LZ5-egmQ@mail.gmail.com>
On 21/07/2022 18:43, Doug Anderson wrote:
> Hi,
>
> On Thu, Jul 21, 2022 at 9:33 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 21/07/2022 15:37, Doug Anderson wrote:
>>>
>>> Not worth sending a new version for, but normally I expect the
>>> bindings to be patch #1 and the dts change to be patch #2. In any
>>> case:
>>>
>>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>>
>> I would say worth v4, because otherwise patches is not bisectable.
>
> You're saying because `dtbs_check` will fail between the two?
Yes
> How does
> flipping the order help? If `dtbs_check` needs to be bisectable then
> these two need to be one patch, but I was always under the impression
> that we wanted bindings patches separate from dts patches.
I don't think anyone said that bindings patches must be separate from
DTS. The only restriction is DTS cannot go with drivers.
Bindings for boards go pretty often with DTS (subarch). This is exactly
what maintainers do, e.g.:
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/log/?h=arm64-for-5.20
Bindings for hardware should go via subsystem maintainer (drivers).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-21 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 3:58 [PATCH v3 1/2] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade Yunlong Jia
2022-07-21 3:58 ` [PATCH v3 2/2] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel Yunlong Jia
2022-07-21 6:47 ` Krzysztof Kozlowski
2022-07-21 13:37 ` Doug Anderson
2022-07-21 16:33 ` Krzysztof Kozlowski
2022-07-21 16:43 ` Doug Anderson
2022-07-21 16:52 ` Krzysztof Kozlowski [this message]
2022-07-21 18:29 ` Doug Anderson
2022-07-22 0:22 ` Rob Herring
2022-07-22 15:41 ` Doug Anderson
2022-07-22 17:16 ` Krzysztof Kozlowski
2022-07-22 17:14 ` Krzysztof Kozlowski
2022-07-22 17:23 ` Doug Anderson
2022-07-22 17:26 ` Krzysztof Kozlowski
2022-07-21 13:36 ` [PATCH v3 1/2] arm64: dts: qcom: Add SKU6 for sc7180-trogdor-pazquel-lte-parade Doug Anderson
2022-07-22 17:55 ` Doug Anderson
2022-08-29 23:46 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2b03863-2249-13e6-98e0-731c1b40d0a9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=henrysun@google.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=robh+dt@kernel.org \
--cc=yunlong.jia@ecs.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).