From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org
Cc: Janosch Frank <frankja@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Martin KaFai Lau <kafai@fb.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Paul Mackerras <paulus@samba.org>, Shuah Khan <shuah@kernel.org>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org, clang-built-linux@googlegroups.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] tools: do not include scripts/Kbuild.include
Date: Fri, 16 Apr 2021 15:27:39 +0200 [thread overview]
Message-ID: <c2b0b348-e114-14d0-44c0-11d0ce6f7760@redhat.com> (raw)
In-Reply-To: <ee99eb80-5711-9349-23a4-0faf8d7b60a8@de.ibm.com>
On 16/04/21 15:26, Christian Borntraeger wrote:
>
>
> On 16.04.21 15:00, Masahiro Yamada wrote:
>> Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to
>> scripts/Makefile.compiler"), some kselftests fail to build.
>>
>> The tools/ directory opted out Kbuild, and went in a different
>> direction. They copy any kind of files to the tools/ directory
>> in order to do whatever they want in their world.
>>
>> tools/build/Build.include mimics scripts/Kbuild.include, but some
>> tool Makefiles included the Kbuild one to import a feature that is
>> missing in tools/build/Build.include:
>>
>> - Commit ec04aa3ae87b ("tools/thermal: tmon: use "-fstack-protector"
>> only if supported") included scripts/Kbuild.include from
>> tools/thermal/tmon/Makefile to import the cc-option macro.
>>
>> - Commit c2390f16fc5b ("selftests: kvm: fix for compilers that do
>> not support -no-pie") included scripts/Kbuild.include from
>> tools/testing/selftests/kvm/Makefile to import the try-run macro.
>>
>> - Commit 9cae4ace80ef ("selftests/bpf: do not ignore clang
>> failures") included scripts/Kbuild.include from
>> tools/testing/selftests/bpf/Makefile to import the .DELETE_ON_ERROR
>> target.
>>
>> - Commit 0695f8bca93e ("selftests/powerpc: Handle Makefile for
>> unrecognized option") included scripts/Kbuild.include from
>> tools/testing/selftests/powerpc/pmu/ebb/Makefile to import the
>> try-run macro.
>>
>> Copy what they need into tools/build/Build.include, and make them
>> include it instead of scripts/Kbuild.include.
>>
>> Link:
>> https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f45a1@linux.ibm.com/
>>
>> Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to
>> scripts/Makefile.compiler")
>> Reported-by: Janosch Frank <frankja@linux.ibm.com>
>> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> looks better.
> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
Thank you very much Masahiro, this look great.
Paolo
next prev parent reply other threads:[~2021-04-16 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 13:00 [PATCH v2] tools: do not include scripts/Kbuild.include Masahiro Yamada
2021-04-16 13:26 ` Christian Borntraeger
2021-04-16 13:27 ` Paolo Bonzini [this message]
2021-04-16 15:39 ` Yonghong Song
2021-04-17 14:57 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2b0b348-e114-14d0-44c0-11d0ce6f7760@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=frankja@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).