From: kajoljain <kjain@linux.ibm.com>
To: Thomas Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org
Cc: svens@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com,
heiko.carstens@de.ibm.com
Subject: Re: [PATCH] perf test: Omit test 68 for s390.
Date: Thu, 19 Nov 2020 19:25:14 +0530 [thread overview]
Message-ID: <c2c7cd99-0e89-8d20-a8e9-42df49656c68@linux.ibm.com> (raw)
In-Reply-To: <20201104082954.57338-1-tmricht@linux.ibm.com>
On 11/4/20 1:59 PM, Thomas Richter wrote:
> Commit ed21d6d7c48e6e ("perf tests: Add test for PE binary format support")
> adds a WINDOWS EXE file named tests/pe-file.exe, which is
> examined by the test case 'PE file support'.
>
> This test reads the buildid from the file tests/pe-file.exe,
> which is a Portable Executable (PE) binary file used by the
> Windows operating system.
>
> Since s390 does not support PE files, omit this test.
>
> Output before:
> [root@t35lp46 perf]# ./perf test -F 68
> 68: PE file support : Failed!
> [root@t35lp46 perf]#
>
> Output after:
> [root@t35lp46 perf]# ./perf test -F 68
> 68: PE file support : Skip
> [root@t35lp46 perf]#
>
>
Patch looks good to me. Thanks for correcting it. Since in powerpc also we are having similar issue,
I send patch on top of this change.
Reviewed-By: Kajol Jain<kjain@linux.ibm.com>
Thanks,
Kajol Jain
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> ---
> tools/perf/tests/pe-file-parsing.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/pe-file-parsing.c b/tools/perf/tests/pe-file-parsing.c
> index 58b90c42eb38..4e45178c50f6 100644
> --- a/tools/perf/tests/pe-file-parsing.c
> +++ b/tools/perf/tests/pe-file-parsing.c
> @@ -18,7 +18,7 @@
>
> #include "tests.h"
>
> -#ifdef HAVE_LIBBFD_SUPPORT
> +#if defined(HAVE_LIBBFD_SUPPORT) && !defined(__s390x__)
>
> static int run_dir(const char *d)
> {
>
prev parent reply other threads:[~2020-11-19 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 8:29 [PATCH] perf test: Omit test 68 for s390 Thomas Richter
2020-11-19 13:50 ` [PATCH] perf test: Skip test 68 for Powerpc Kajol Jain
2020-11-24 9:34 ` Ravi Bangoria
2020-12-07 16:35 ` Arnaldo Carvalho de Melo
2020-12-08 14:43 ` Thomas Richter
2020-12-08 17:02 ` Ravi Bangoria
2020-12-09 17:49 ` Arnaldo Carvalho de Melo
2020-12-10 5:52 ` Ravi Bangoria
2020-12-09 17:37 ` Arnaldo Carvalho de Melo
2020-11-19 13:55 ` kajoljain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c7cd99-0e89-8d20-a8e9-42df49656c68@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=acme@kernel.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sumanthk@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).